ode: revert from cmake to autotools, disable demos #167721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The switch to use cmake in Homebrew#167158 changed the configuration options in a way that affects downstream users, so this reverts that change until cmake can be used with the same configuration. Also use the `--disable-demos` argument.
there was no particular reason, when both build options available, I just prefer to use cmake rather than autotools, the build is more streamlined in the cmake way. Open to such change though. |
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
|
bump revisions for dartsim and ompl due to the linkage issues |
fxcoudert
approved these changes
Apr 2, 2024
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This was referenced Apr 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?The switch to use cmake instead of autotools in #167158 changed the configuration options in a way that affects downstream users, so this reverts that change until cmake can be used with the same configuration. I attempted to fix the cmake configuration in #167521, but ran into some errors in the upstream cmake. I will submit cmake fixes to upstream, but am opening this revert PR in the meantime.
This also adds the
--disable-demosargument since the demos are not installed and to sidestep a compilation error in one of the demos.