Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DetachableJointTest.CorrectAttachmentPoints dartsim test fails on Homebrew CI #612

Closed
iche033 opened this issue Mar 29, 2024 · 2 comments · Fixed by #615
Closed

DetachableJointTest.CorrectAttachmentPoints dartsim test fails on Homebrew CI #612

iche033 opened this issue Mar 29, 2024 · 2 comments · Fixed by #615
Labels
bug Something isn't working macOS Mac OSX support

Comments

@iche033
Copy link
Contributor

iche033 commented Mar 29, 2024

The DetachableJointTest.CorrectAttachmentPoints dartsim test started failing. This is likely caused by the new ODE 0.16.5 bottle, see #611 (comment)

Environment

  • OS Version: macOS homebrew
  • Source or binary build? gz-physics7 and main branches on homebrew jenkins

Description

  • Expected behavior: All tests pass on homebrew
  • Actual behavior: DetachableJointTest.CorrectAttachmentPoints fails a position check after detaching joint (dartsim plugin, homebrew)

Output

Test failure output from homebrew jenkins:

59: Testing plugin: gz::physics::dartsim::Plugin
59: /Users/jenkins/jenkins-agent/workspace/gz_physics-ci-pr_any-homebrew-amd64/gz-physics/test/common_test/detachable_joint.cc:190: Failure
59: The difference between 0.15 and frameDataC1L1.pose.translation().z() is 0.10148802840906343, which exceeds 1e-2, where
59: 0.15 evaluates to 0.14999999999999999,
59: frameDataC1L1.pose.translation().z() evaluates to 0.048511971590936565, and
59: 1e-2 evaluates to 0.01.
@scpeters
Copy link
Member

potential fix in Homebrew/homebrew-core#167521

@scpeters
Copy link
Member

scpeters commented Apr 2, 2024

Actual fix in Homebrew/homebrew-core#167721, reverting the workaround in #615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working macOS Mac OSX support
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants