Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jpeg-xl 0.8.2: add upstream patch to fix build for older macOS #156953

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

Jerry1144
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

As per libjxl/libjxl#2483, there are build failures that have upstream fixes already, but not in current 0.8.2 version. Relevant changes are made into a patch to facilitate users still waiting for 0.8.3. Also removed fail_with :clang <= 1000 line as the patch fixed this AVX512 error (#128495).

As per libjxl/libjxl#2483, there are build failures
that have upstream fixes already, but not in current 0.8.2 version. Relevant
changes are made into a patch to facilitate users still waiting for 0.8.2.
Removed fail_with :clang <= 1000 line as the patch fixed this AVX512 error.
@Bo98 Bo98 added CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot. labels Dec 11, 2023
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@Bo98 Bo98 added this pull request to the merge queue Dec 11, 2023
Merged via the queue into Homebrew:master with commit 4f766da Dec 11, 2023
20 of 27 checks passed
@Jerry1144 Jerry1144 deleted the jpeg-xl branch December 12, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants