Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jpeg-xl: record build failure with Apple Clang build 1000 #128495

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

whitslack
Copy link
Contributor

jpeg-xl fails to build with Apple Clang 1000:

lib/jxl/enc_fast_lossless.cc:369:7: error: invalid cpu feature string for builtin
  if (__builtin_cpu_supports("avx512vbmi2")) {
      ^                      ~~~~~~~~~~~~~

Adding an appropriate fails_with block lets Homebrew use llvm_clang instead, which works.


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
    • No, because the test code is trying to execute ENV.cc, which evaluates to llvm_clang, but no executable by that name is found in my PATH. Either the ENV.cc variable should be set to /usr/local/Homebrew/Library/Homebrew/shims/mac/super/llvm_clang, or /usr/local/Homebrew/Library/Homebrew/shims/mac/super should be temporarily appended to PATH while running the test.
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@carlocab carlocab added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Apr 16, 2023
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab added this pull request to the merge queue Apr 16, 2023
Merged via the queue into Homebrew:master with commit 0cee509 Apr 16, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label May 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2023
@whitslack whitslack deleted the jpeg-xl branch August 4, 2023 03:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants