Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biome: improve version test #143440

Closed
wants to merge 1 commit into from
Closed

biome: improve version test #143440

wants to merge 1 commit into from

Conversation

nhedger
Copy link
Contributor

@nhedger nhedger commented Sep 17, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This PR improves the version check in the test block introduced in #143196.

The current test relies on biome --version returning a exit code of 1, which is a bug.

This test uses the biome version command instead, which returns the correct exit code.

Because the format is slightly different, I've used a Regex to do this one.

/cc @chenrui333

@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Sep 17, 2023
@chenrui333
Copy link
Member

chenrui333 commented Sep 17, 2023

Thanks for the PR, but there is no need to do such complicated test, let's wait for the upstream's status code fix.

@chenrui333 chenrui333 closed this Sep 17, 2023
@nhedger nhedger deleted the biome-test-version branch September 17, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants