Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

biome 1.2.0 (new formula) #143196

Merged
merged 2 commits into from
Sep 17, 2023
Merged

biome 1.2.0 (new formula) #143196

merged 2 commits into from
Sep 17, 2023

Conversation

nhedger
Copy link
Contributor

@nhedger nhedger commented Sep 16, 2023 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Hey,

I'm submitting this formula for the Biome project to distribute the biome CLI via Homebrew.

I have a couple of questions:

  • Should we add the biome formula to the list of formulae in the autobump workflow if we want Homebrew to update the formula when a new version is released?
    • Should I PR the changes in this PR or a separate PR?
  • If so, will Homebrew handle updating the git revision automatically?

Thanks for your time.

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Sep 16, 2023
chenrui333
chenrui333 reviewed Sep 16, 2023
View reviewed changes
Formula/b/biome.rb Outdated Show resolved Hide resolved
chenrui333
chenrui333 reviewed Sep 16, 2023
View reviewed changes
Formula/b/biome.rb Outdated Show resolved Hide resolved
chenrui333
chenrui333 reviewed Sep 16, 2023
View reviewed changes
Formula/b/biome.rb Outdated Show resolved Hide resolved
chenrui333
chenrui333 reviewed Sep 16, 2023
View reviewed changes
Formula/b/biome.rb Outdated Show resolved Hide resolved
@chenrui333
Copy link
Member

chenrui333 commented Sep 16, 2023 •
edited
Loading

👋 @nhedger thanks for your first PR to homebrew-core!

I have a couple of questions:

  • Should we add the biome formula to the list of formulae in the autobump workflow if we want Homebrew to update the formula when a new version is released?

    • Should I PR the changes in this PR or a separate PR?

  • If so, will Homebrew handle updating the git revision automatically?

If possible, you can help adding either bump-homebrew-formula-action or action-homebrew-bump-formula into the release pipeline to automate the homebrew releases

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 16, 2023
@nhedger @chenrui333
biome 1.2.0 (new formula)
11f6ef7 
simplify build

Co-authored-by: Rui Chen <[email protected]>

simplify test

Co-authored-by: Rui Chen <[email protected]>

simplify test

Co-authored-by: Rui Chen <[email protected]>

use tarball instead of git clone

Co-authored-by: Rui Chen <[email protected]>

biome: update test

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Sep 17, 2023
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 17, 2023
chenrui333
chenrui333 reviewed Sep 17, 2023
View reviewed changes
Formula/b/biome.rb
system bin/"biome", "format", "--semicolons=always", "--write", testpath/"test.js"
assert_match "const x = 1;", (testpath/"test.js").read

assert_match version.to_s, shell_output("#{bin}/biome --version", 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is some status code issue with version check, this can be reported to upstream

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll look into it. Is this a blocker for merging here ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a blocker, but just call it out.

@github-actions
Copy link
Contributor

:shipit: @chenrui333 has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 17, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 17, 2023
Merged via the queue into Homebrew:master with commit 7d4ab65 Sep 17, 2023
@nhedger nhedger mentioned this pull request Sep 17, 2023
Closed
6 tasks
@nhedger nhedger deleted the biome branch September 17, 2023 17:52
@nhedger nhedger mentioned this pull request Sep 17, 2023
Closed
4 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nhedger @chenrui333 @BrewTestBot