Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corelocationcli: migrate to cask #12109

Merged
merged 1 commit into from
Apr 12, 2017
Merged

corelocationcli: migrate to cask #12109

merged 1 commit into from
Apr 12, 2017

Conversation

fulldecent
Copy link
Contributor

@fulldecent fulldecent commented Apr 5, 2017 •
edited
Loading

see Homebrew/homebrew-cask#31827 (comment)

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@fulldecent fulldecent mentioned this pull request Apr 5, 2017
Merged
9 tasks
ilovezfs
ilovezfs suggested changes Apr 12, 2017
View reviewed changes
Copy link
Contributor

@ilovezfs ilovezfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this to the tap_migrations file.

@ilovezfs ilovezfs added the marked for removal/rejection PR is probably going to be closed or formula deleted label Apr 12, 2017
@fulldecent @ilovezfs
corelocationcli: migrate to cask
b381c85 
needs to be code signed to be fully functional
@ilovezfs ilovezfs changed the title Remove corelocationcli since it requires signing corelocationcli: migrate to cask Apr 12, 2017
@ilovezfs
Copy link
Contributor

I took care of adding it to the tap migrations file.

@ilovezfs ilovezfs merged commit da2a638 into Homebrew:master Apr 12, 2017
@ilovezfs
Copy link
Contributor

Thanks for doing this migration @fulldecent 🚀

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilovezfs ilovezfs ilovezfs approved these changes

Assignees
No one assigned
Labels
marked for removal/rejection PR is probably going to be closed or formula deleted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fulldecent @ilovezfs