Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CoreLocationCLI v2.2.0 #31827

Merged
merged 5 commits into from
Apr 12, 2017
Merged

Conversation

fulldecent
Copy link
Contributor

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the [token reference].
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no [open pull requests] for the same cask.
  • Checked the cask was not already refused in [closed issues].
  • Checked the cask is submitted to [the correct repo].

Previously this was in Homebrew main. This is a CLI open source app. BUT it requires signing because it uses CoreLocation and it no longer works in Homebrew main. That is why I am submitting to Homebrew Cask.

Discussion:

fulldecent/corelocationcli#14

@miccal
Copy link
Member

miccal commented Apr 4, 2017

audit for corelocationcli: warning
 - possible duplicate, cask token conflicts with Homebrew core formula:
https://github.com/Homebrew/homebrew-core/blob/master/Formula/corelocationcli.rb

Ping @vitorgalvao for review.

@numbermaniac
Copy link
Contributor

numbermaniac commented Apr 4, 2017

It still exists in Homebrew - are you planning on removing it there first, @fulldecent ?

@vitorgalvao
Copy link
Member

This is a CLI-only open-source tool. As stated, it belongs in Homebrew/core.

This policy is documented in faq/rejected_casks:

The app is both open-source and CLI-only (i.e. it only uses the binary artifact). In that case, and in the spirit of deduplication, submit it first to Homebrew/core. If it is rejected there, you may then try again in Homebrew-Cask (link us to the issue on Homebrew so we can see their reasoning for rejection).

It may only be added here if it’s remove from there, for some reason.

@fulldecent
Copy link
Contributor Author

Removing, please see Homebrew/homebrew-core#12109

@fulldecent
Copy link
Contributor Author

Please note: audit failed per note above. This is ready for merge.

@vitorgalvao
Copy link
Member

@fulldecent It’s only ready to merge after it’s removed from the core.

@ilovezfs
Copy link
Contributor

@vitorgalvao 👍 from core for the migration.

@vitorgalvao
Copy link
Member

Thank you, @ilovezfs.

@vitorgalvao vitorgalvao merged commit 84913cd into Homebrew:master Apr 12, 2017
@ilovezfs
Copy link
Contributor

@vitorgalvao no problem. Core PR is merged! Homebrew/homebrew-core#12109

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants