-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CoreLocationCLI v2.2.0 #31827
Add CoreLocationCLI v2.2.0 #31827
Conversation
Ping @vitorgalvao for review. |
It still exists in Homebrew - are you planning on removing it there first, @fulldecent ? |
This is a CLI-only open-source tool. As stated, it belongs in Homebrew/core. This policy is documented in faq/rejected_casks:
It may only be added here if it’s remove from there, for some reason. |
Removing, please see Homebrew/homebrew-core#12109 |
Please note: audit failed per note above. This is ready for merge. |
@fulldecent It’s only ready to merge after it’s removed from the core. |
@vitorgalvao 👍 from core for the migration. |
Thank you, @ilovezfs. |
@vitorgalvao no problem. Core PR is merged! Homebrew/homebrew-core#12109 |
If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:
brew cask audit --download {{cask_file}}
is error-free.brew cask style --fix {{cask_file}}
reports no offenses.Additionally, if adding a new cask:
brew cask install {{cask_file}}
worked successfully.brew cask uninstall {{cask_file}}
worked successfully.Previously this was in Homebrew main. This is a CLI open source app. BUT it requires signing because it uses CoreLocation and it no longer works in Homebrew main. That is why I am submitting to Homebrew Cask.
Discussion:
fulldecent/corelocationcli#14