Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix overeager PK setting for extraction Identifiers #1888

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

JFriel
Copy link
Collaborator

@JFriel JFriel commented Jul 17, 2024

Proposed Change

Issue with extractions attempting to set extraction identifiers as PKs incorrectly.
Tested w/Guneet and it fixes the issue

Type of change

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update
  • Other (if none of the other choices apply)

Checklist

By opening this PR, I confirm that I have:

  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Created or updated any tests if relevant
  • Have validated this change against the Test Plan
  • Requested a review by one of the repository maintainers
  • Have written new documentation or updated existing documentation to detail any new or updated functionality and how to use it
  • Have added an entry into the changelog

@JFriel JFriel requested a review from a team July 17, 2024 12:22
@JFriel JFriel merged commit ef78e00 into develop Jul 17, 2024
6 checks passed
@JFriel JFriel deleted the bugfix-pk-ei-issue branch July 17, 2024 13:58
JFriel added a commit that referenced this pull request Jul 18, 2024
* add cron test

* fix yaml

* fix yaml

* update spacing

* use example

* update cron

* update to push

* add 2am cron

* update yaml

* use utc

* add first update

* add populate function

* add changelog

* update tests

* fix test

* attempt to fix test

* interim

* interim

* add label

* add description field

* add vertical scaling

* working UI

* add tooltips

* working ui

* add to cignorelist

* add changelog entry

* tidy up

* fix typo

* fix codeql

* Task/rdmp-1  Update Ticketing System (#1870)

* add initial ticketing update

* fix patch

* interim

* allow blanks

* pass statuses around

* update tests

* add image

* add resources

* tidy up

* tidy up

* fix build

* add icon

* add image

* fix test

* add changelog

* fix error not poping

* add missing line

* fix typo

* tidy up

* Bump ObjectListView.Repack.NET6Plus from 2.9.4 to 2.9.5

Bumps ObjectListView.Repack.NET6Plus from 2.9.4 to 2.9.5.

---
updated-dependencies:
- dependency-name: ObjectListView.Repack.NET6Plus
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump Terminal.Gui from 1.17.0 to 1.17.1 (#1879)

Bumps Terminal.Gui from 1.17.0 to 1.17.1.

---
updated-dependencies:
- dependency-name: Terminal.Gui
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/setup-dotnet from 4.0.0 to 4.0.1 (#1875)

Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/actions/setup-dotnet/releases)
- [Commits](actions/setup-dotnet@v4.0.0...v4.0.1)

---
updated-dependencies:
- dependency-name: actions/setup-dotnet
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add read onlu to plugins

* update changelog

* Bugfix/rdmp 210: Improve LoadMetadata directory checking (#1884)

* add folders check

* add load directory checks

* add changelog

* update imports

---------

Co-authored-by: James A Sutherland <[email protected]>

* Bump HIC.FAnsiSql from 3.2.5 to 3.2.6 (#1886)

* Delete directory.build.props (#1887)

Remove duplicate file - we have two identical files which differ only in case...

* add changelog

* Bugfix/rdmp 209 default instance (#1889)

* add missing file

* add no reopining

* Bugfix: Fix overeager PK setting for extraction Identifiers (#1888)

* remove ei pk force

* update for tests

* Bump YamlDotNet from 15.3.0 to 16.0.0

Bumps YamlDotNet from 15.3.0 to 16.0.0.

---
updated-dependencies:
- dependency-name: YamlDotNet
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update VersionYamlTypeConverter.cs

Update for new YamlDotNet API

* Update CHANGELOG.md

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Brian <[email protected]>
Co-authored-by: rdteviotdale <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: James A Sutherland <[email protected]>
Co-authored-by: James A Sutherland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants