marge develop into main #1890
Merged
marge develop into main #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sk/RDMP-202-improved-load-metadata-api
…k/RDMP-173-improve-lookup-generator
…b.com/HicServices/RDMP into tak/RDMP-173-improve-lookup-generator
Bugfix/RDMP-188 Attempt fix for 2am UTC issue
…-generator Tak/rdmp 173 improve lookup generator
* add initial ticketing update * fix patch * interim * allow blanks * pass statuses around * update tests * add image * add resources * tidy up * tidy up * fix build * add icon * add image * fix test * add changelog * fix error not poping * add missing line * fix typo * tidy up
…-metadata-api Task/rdmp 202 improved load metadata api
Bumps ObjectListView.Repack.NET6Plus from 2.9.4 to 2.9.5. --- updated-dependencies: - dependency-name: ObjectListView.Repack.NET6Plus dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps Terminal.Gui from 1.17.0 to 1.17.1. --- updated-dependencies: - dependency-name: Terminal.Gui dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v4.0.0...v4.0.1) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bugfix/rdmp 211: Plugin Read/Write Permissions
* add folders check * add load directory checks * add changelog * update imports --------- Co-authored-by: James A Sutherland <[email protected]>
Remove duplicate file - we have two identical files which differ only in case...
* add missing file * add no reopining
* remove ei pk force * update for tests
Bumps YamlDotNet from 15.3.0 to 16.0.0. --- updated-dependencies: - dependency-name: YamlDotNet dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Update for new YamlDotNet API
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| var ticketingSystem = WhenIHaveA<TicketingSystemConfiguration>(repository); | ||
| ticketingSystem.SaveToDatabase(); | ||
| return (T)(object)new TicketingSystemReleaseStatus(repository, "my_status", null, ticketingSystem); |
Check warning
Code scanning / CodeQL
Useless upcast Warning
| { | ||
| var cata = WhenIHaveA<Catalogue>(repository); | ||
|
|
||
| var lmd = WhenIHaveA<LoadMetadata>(repository); | ||
|
|
||
| return (T)(object)new LoadMetadataCatalogueLinkage(repository, lmd,cata); | ||
| return (T)(object)new LoadMetadataCatalogueLinkage(repository, lmd, cata); |
Check warning
Code scanning / CodeQL
Useless upcast Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Summarise your proposed changes here, including any notes for reviewers.
Type of change
What types of changes does your code introduce? Tick all that apply.
Checklist
By opening this PR, I confirm that I have: