Refactor Skill Copy via Plagiarism and Reproduce #2948

MrKeiKun · 2021-02-12T16:04:16Z

I have followed proper Hercules code styling.
I have read and understood the contribution guidelines before making this PR.
I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

PR should:

Remove hard coded list of skills that can be copied by Reproduce
Refactor method of what skills can be plagiarized and reproduced
Remove copyskill_restrict config
Fix [RE] Unable to Reproduce skill when Preserve is active #989 and Skill Missing on Plagirism/Reproduce #2940
Players can copy skills from another player or monster(Except: Reproduce cannot copy skills from monsters)
Recheck total list of skills that can be copied under 3rd jobs.

Issues addressed:

src/map/skill.c

Separated Plagiarized and Reproduced skill list.

…ist and improve way of checking skill_id and it's index.

MrKeiKun force-pushed the fix-plagiarism_x_reproduce branch 5 times, most recently from da15403 to ee8077d Compare February 19, 2021 14:50

MrKeiKun force-pushed the fix-plagiarism_x_reproduce branch from ee8077d to 6d89920 Compare March 21, 2021 07:28

MrKeiKun force-pushed the fix-plagiarism_x_reproduce branch from 6d89920 to 8c1fa75 Compare April 6, 2021 18:59

skyleo requested changes Jul 8, 2021

View reviewed changes

src/map/skill.c Show resolved Hide resolved

skyleo added the status:inprogress Issue is being worked on / the pull request is still a WIP label Jul 8, 2021

MrKeiKun force-pushed the fix-plagiarism_x_reproduce branch from 8c1fa75 to d970fa7 Compare September 6, 2021 03:50

MrKeiKun force-pushed the fix-plagiarism_x_reproduce branch 3 times, most recently from 2ed8a59 to 46856fe Compare October 31, 2021 22:00

MishimaHaruna added this to the Release v2022.07.06 milestone Jun 1, 2022

MrKeiKun added 8 commits June 2, 2022 19:50

Refactored method of copying skills via Plagiarism and Reproduce.

67e8ce6

Separated Plagiarized and Reproduced skill list.

Split list of skills that can be copied via Plagiarism and Reproduce.

2ad9835

Removed copyskill_restrict config.

20dd38f

Added INF2_ALLOW_PLAGIARIZE for skill_validate_skillinfo.

9fb660c

Moved skill idx check inside can_copy().

93045ed

Updated list of pre-re skill that can be copied via plagiarism.

dfd917b

Fixed issue where skill can be copied even its already in the skill-l…

d57c063

…ist and improve way of checking skill_id and it's index.

Enable some skills to be copied on renewal.

c25fab8

MrKeiKun force-pushed the fix-plagiarism_x_reproduce branch from 46856fe to c25fab8 Compare June 2, 2022 11:50

MishimaHaruna approved these changes Aug 15, 2022

View reviewed changes

MishimaHaruna merged commit c01d439 into HerculesWS:master Aug 15, 2022

MishimaHaruna removed the status:inprogress Issue is being worked on / the pull request is still a WIP label Oct 6, 2022

Provide feedback