[js] Added "-D js-global" to customizes the global object name #10282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R32
changed the title
| @@ -1912,7 +1917,7 @@ let generate com = | |||
| in | |||
| (* Provide console for environments that may not have it. *) | |||
| let closureArgs = if ctx.es_version < 5 then | |||
| var_console :: closureArgs | |||
| ("console", typeof_join ["console"; "{log:function(){}}"]) :: closureArgs | |||
There was a problem hiding this comment.
Does any js environments miss console implementation?
There was a problem hiding this comment.
In IE8/9 the console only works when F12 is pressed
|
I do remember someone targetting Rhino with Haxe, some googling suggests console is not part of standard javascript, and should not be assumed for any js used in embedded systems. |
RealyUniqueName
added a commit
that referenced
this pull request
Jun 24, 2021
* Added "-D js-global" * minor format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10258
It's used in some strange js environments, for example: You can use
-D js-global=GameGlobalfor WeChat mini-games,And the one corresponding to AudioWorklet is
-D js-global=globalThisEven for nodejs, the code generated by
-D js-global=globalis more cleaner when you use@:expose