Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Unicode Combining Diacritical Marks in FlxBitmapText #2309

Merged
merged 5 commits into from
Jul 3, 2021

Conversation

SeiferTim
Copy link
Member

For applyng Underlines, Umlauts, and other combination characters to your Bitmap Text.
More information: https://en.wikipedia.org/wiki/Combining_Diacritical_Marks

Example Usage: add an underline character to your BitmapFont and give it the Id of 818 (Decimal for U+0332), make sure it is as wide as your widest xadvance + letterspacing for your font. Set it's xadvance = 0

In your code, set your FlxBitmapText.text = "This M\u0332 is Underlined!"; and it should show up with the letter M underlined!

…xt`s

For apply Underlines, Umlauts, and other combination characters to your Bitmap Text.
More information: https://en.wikipedia.org/wiki/Combining_Diacritical_Marks

Example Usage: add an underline character to your BitmapFont and give it the Id of 818 (Decimal for U+0332), make sure it is as wide as your widest xadvance + letterspacing for your font. Set it's xadvance = 0

In your code, set your `FlxBitmapText.text = "This M\u0332 is Underlined!";` and it should show up with the letter M underlined!
@Gama11
Copy link
Member

Gama11 commented May 29, 2021

That diff primarily seems to consist of unrelated formatting changes...

@Beeblerox Beeblerox mentioned this pull request Jun 3, 2021
1 task
Fixing unintended formatting changes.
Fixing unintended formatting changes.
Copy link
Member

@Gama11 Gama11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a few examples of this feature in the FlxBitmapText demo.

flixel/text/FlxBitmapText.hx Outdated Show resolved Hide resolved
flixel/text/FlxBitmapText.hx Outdated Show resolved Hide resolved
flixel/text/FlxBitmapText.hx Outdated Show resolved Hide resolved
flixel/graphics/frames/FlxBitmapFont.hx Outdated Show resolved Hide resolved
flixel/text/FlxBitmapText.hx Outdated Show resolved Hide resolved
flixel/text/FlxBitmapText.hx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants