feat: add network settings screen #701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroferreira1
force-pushed
the
feat/network-settings
branch
from
c9fa052 to
fddf771
Compare
tuliomir
reviewed
Dec 8, 2024
Comment on lines
-158
to
-161
| config.setServerUrl(serverUrl); | ||
| config.setNetwork(networkName); | ||
| LOCAL_STORE.setServers(serverUrl); | ||
| LOCAL_STORE.setNetwork(networkName); |
Comment on lines
+127
to
134
| let networkSettings = LOCAL_STORE.getNetworkSettings(); | ||
| if (!networkSettings) { | ||
| // If it doesn't exist in the store, it's a fresh install | ||
| // or a migration from older versions, so we just use the | ||
| // default network from the lib | ||
| const libDefaultNetwork = hathorLib.config.getNetwork().name; | ||
| networkSettings = NETWORK_SETTINGS[network]; | ||
| } |
There was a problem hiding this comment.
suggestion(non-blocking): We have two instances of this same code. It could be nice to have something like a safeGetNetworkSettings(), and it feels to me that it could be on the LOCAL_STORE or even on this helpers file.
| @@ -97,7 +97,8 @@ const wallet = { | |||
| * @return {boolean} boolean indicating if address is valid | |||
| */ | |||
| validateAddress(address) { | |||
| const networkName = LOCAL_STORE.getNetwork() || 'mainnet'; | |||
| const networkSettings = LOCAL_STORE.getNetworkSettings(); | |||
| const networkName = networkSettings ? networkSettings.network : 'mainnet'; | |||
There was a problem hiding this comment.
thought(non-blocking): This could also be benefited by this "safeGet" suggestion.
Comment on lines
+64
to
+69
| NETWORKSETTINGS_REQUEST_UPDATE: 'NETWORKSETTINGS_REQUEST_UPDATE', | ||
| NETWORKSETTINGS_UPDATE: 'NETWORKSETTINGS_UPDATE', | ||
| NETWORKSETTINGS_SET_STATUS: 'NETWORKSETTINGS_SET_STATUS', |
There was a problem hiding this comment.
Suggested change
| NETWORKSETTINGS_REQUEST_UPDATE: 'NETWORKSETTINGS_REQUEST_UPDATE', | |
| NETWORKSETTINGS_UPDATE: 'NETWORKSETTINGS_UPDATE', | |
| NETWORKSETTINGS_SET_STATUS: 'NETWORKSETTINGS_SET_STATUS', | |
| NETWORKSETTINGS_UPDATE_REQUESTED: 'NETWORKSETTINGS_UPDATE_REQUESTED', | |
| NETWORKSETTINGS_UPDATED: 'NETWORKSETTINGS_UPDATED', | |
| NETWORKSETTINGS_SET_STATUS: 'NETWORKSETTINGS_SET_STATUS', |
Comment on lines
+81
to
+91
| if (networkSettings.status === NETWORK_SETTINGS_STATUS.LOADING) { | ||
| setLoading(true); | ||
| } | ||
|
|
||
| if (networkSettings.status === NETWORK_SETTINGS_STATUS.ERROR) { | ||
| setErrorMessage(networkSettings.error) | ||
| setLoading(false); | ||
| } | ||
|
|
||
| if (networkSettings.status === NETWORK_SETTINGS_STATUS.READY) { | ||
| setLoading(false); |
There was a problem hiding this comment.
Do you really need to set state here?
pedroferreira1
force-pushed
the
feat/network-settings
branch
from
ab84740 to
16265fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Version migration:
All users will start this new version on mainnet. I think this is ok and doesn't hurt anyone, since it's really easy to change networks now.
Screen.Recording.2024-12-02.at.23.03.15.mov
Security Checklist