Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Network name inconsistency #547

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix: Network name inconsistency #547

merged 2 commits into from
Mar 20, 2024

Conversation

tuliomir
Copy link
Collaborator

@tuliomir tuliomir commented Mar 5, 2024

This is a complement of #537 : , it fixed all tested cases for software wallets. However when testing hardware wallets on testnet some new errors appeared. This PR fixes them.

The cause is that the network name was never updated on local store for a hardware wallet.

Acceptance Criteria

  • The application should run a hardware wallet successfully on testnet
  • After closing and opening the application again, the application should not throw any errors and continue on testnet

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the bug Something isn't working label Mar 5, 2024
@tuliomir tuliomir self-assigned this Mar 5, 2024
@tuliomir tuliomir requested a review from pedroferreira1 as a code owner March 5, 2024 16:39
@tuliomir tuliomir requested a review from r4mmer March 5, 2024 16:39
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 9.22%. Comparing base (2525524) to head (03e7411).

Files Patch % Lines
src/sagas/wallet.js 0.00% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #547      +/-   ##
=========================================
- Coverage    9.22%   9.22%   -0.01%     
=========================================
  Files         112     112              
  Lines        5246    5248       +2     
  Branches      700     701       +1     
=========================================
  Hits          484     484              
- Misses       4097    4098       +1     
- Partials      665     666       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/sagas/wallet.js Show resolved Hide resolved
src/sagas/wallet.js Show resolved Hide resolved
@tuliomir tuliomir force-pushed the fix/ledger-server branch from eba93b2 to 03e7411 Compare March 19, 2024 23:44
@tuliomir tuliomir merged commit b07a82d into master Mar 20, 2024
3 checks passed
@tuliomir tuliomir deleted the fix/ledger-server branch March 20, 2024 17:45
@tuliomir tuliomir mentioned this pull request Mar 25, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants