Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge release-candidate into release #570

Merged
merged 11 commits into from
Apr 2, 2024
Merged

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented Apr 2, 2024

No description provided.

tuliomir and others added 11 commits March 4, 2024 14:41
* fix: invalid token crash on network change

* fix: crash on reload wallet

* fix: crash when resetting wallet on testnet

* fix: updates local store besides the lib config
* feat: wallet-service start wallet

* chore: clean comment
* fix: failsafing also the network name

* refactor: setting network name
* fix: Ledger modal not updating on SendTokens

* fix: restores mandatory `cb` param

* fix: event handlers out of sync

* refactor: external variable moved to useRef

* feat: adds modalState param
* feat: initial wallet service qa

* Update QA_WALLET_SERVICE.md

Co-authored-by: Pedro Ferreira <[email protected]>

* docs: send tx with htr and custom token to wallet-service qa

* chore: review changes

---------

Co-authored-by: Pedro Ferreira <[email protected]>
* fix: clean localStorage for hardware migrations

* feat: also persist app:uniqueId

* chore: remove unnecessary flags
* feat: add menu to reset storage

* feat: confirm reset data modal

* feat: move reset menu into debug

* chore: review changes

* chore: review changes
* docs: hardware wallet migration qa

* chore: remove useless link

* docs: check the reset menu on the QA
Start release-candidate for v0.28.0
@r4mmer r4mmer requested a review from tuliomir April 2, 2024 18:07
@r4mmer r4mmer self-assigned this Apr 2, 2024
@r4mmer r4mmer requested a review from pedroferreira1 as a code owner April 2, 2024 18:07
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 1.40845% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 9.18%. Comparing base (afbddb8) to head (d86bd2b).

Files Patch % Lines
src/screens/SendTokens.js 0.00% 22 Missing and 2 partials ⚠️
src/components/ModalConfirmClearStorage.js 0.00% 14 Missing and 1 partial ⚠️
src/sagas/wallet.js 0.00% 9 Missing and 3 partials ⚠️
src/utils/helpers.js 0.00% 6 Missing and 1 partial ⚠️
src/App.js 0.00% 5 Missing ⚠️
src/components/RequestError.js 0.00% 3 Missing ⚠️
src/screens/Server.js 0.00% 1 Missing and 1 partial ⚠️
src/sagas/featureToggle.js 0.00% 1 Missing ⚠️
src/screens/Wallet.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           release    #570      +/-   ##
==========================================
- Coverage     9.20%   9.18%   -0.02%     
==========================================
  Files          112     113       +1     
  Lines         5259    5269      +10     
  Branches       698     703       +5     
==========================================
  Hits           484     484              
- Misses        4112    4117       +5     
- Partials       663     668       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r4mmer r4mmer merged commit d24f959 into release Apr 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants