Skip to content

Commit

Permalink
upgrade angular, fix #1786
Browse files Browse the repository at this point in the history
  • Loading branch information
@paglias
paglias committed Nov 16, 2013
1 parent fb1cc7b commit 20f9e6b
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions bower.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
"jquery": "~2.0.3",
"jquery.cookie": "~1.4.0",
"jquery-ui": "~1.10.3",
"angular": "1.2.0-rc.3",
"angular-sanitize": "1.2.0-rc.3",
"angular-resource": "1.2.0-rc.3",
"angular": "~1.2.1",
"angular-sanitize": "~1.2.1",
"angular-resource": "~1.2.1",
"angular-ui": "~0.4.0",
"angular-ui-utils": "~0.0.4",
"angular-bootstrap": "~0.5.0",
Expand All @@ -39,9 +39,9 @@
"resolutions": {
"jquery": "~2.0.3",
"bootstrap": "v2.3.2",
"angular": "1.2.0-rc.3"
"angular": "~1.2.1"
},
"devDependencies": {
"angular-mocks": "1.2.0-rc.3"
"angular-mocks": "~1.2.1"
}
}

7 comments on commit 20f9e6b

@lefnire
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paglias @snicker @SabreCat I'm getting minification error when deploying to beta. I'm not sure if it's this commit, but fb1cc7b was the last commit that was deployed to production & beta, and since then something got broken. I tried the following to figure out which commit it was:

$ git bisect start
$ git bisect good fb1cc7b
$ git bisect bad
$ npm install
$ ./node_modules/.bin/grunt build:prod;NODE_ENV=production ./node_modules/.bin/grunt nodemon;
$ (repeat last 3 steps until bisect is complete)

But I couldn't get it to trigger consistently using bisect. This is the faulty commit range. My hunch was upgrading to Angular 1.2.1, but I tried rolling back Angular to 1.2.0-rc.3 and pushing to beta and no cigar. It might be some other bower component we don't expect. I'll keep digging when I get the chance (I probably just need to refine my bisect approach), and it's not critical, we can just stay on an older release on beta & production for now.

@paglias
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably my fault, I'm giving a look at it, could be a commit on habitrpg-shared

@paglias
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lefnire I would say it's HabitRPG/habitrpg-shared@4547417

@paglias
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lefnire it's fixed with 7cae5b6

The problem is that the minifed app.js got created with a starting "use strict" which broke MomentJS 2.4.0, see moment/moment#1179

It's working setting in UglifyJS settings compress: false, but we get a build of 555kb instead of 536kb. I still have to understand why UglifyJS puts a "use strict" at the beginning of the build file without an option to disable it...

@paglias
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a fix is coming in the next momentjs release, let's save this discussion and wait for it then

@lefnire
Copy link
Contributor

@lefnire lefnire commented on 20f9e6b Nov 17, 2013 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paglias
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some googling :)

Please sign in to comment.