Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 1.2.0 stable is broken #1786

Closed
paglias opened this issue Nov 10, 2013 · 5 comments
Closed

Angular 1.2.0 stable is broken #1786

paglias opened this issue Nov 10, 2013 · 5 comments
Assignees

Comments

@paglias
Copy link
Contributor

paglias commented Nov 10, 2013

@lefnire just a reminder that angular 1.2.0 is broken.

They "decided" that all properties starting with a _ are to be considered private so they can't be used inside the templates.

It brokes a lot of thing and I don't feel we can change this easily.

The error is this http://docs.angularjs.org/error/$parse:isecprv?p0=_id and I really hope they'll revert the commit (angular/angular.js@3d6a89e) because it's completely preventig us to upgrade.

@ghost ghost assigned paglias Nov 10, 2013
@lefnire
Copy link
Contributor

lefnire commented Nov 10, 2013

Ohhh shoot.. Derby made that decision in 0.5 as well, yeah we're using ._ in many places. Good to know, thanks for the heads up - I'll start thinking about this

@lefnire
Copy link
Contributor

lefnire commented Nov 12, 2013

You know what - I was thinking, "well we can remove all our private fields from the app and come up with something cleaner" - and then remembered we have User._v. We're gonna have to wait this one out and follow that convo.

@paglias
Copy link
Contributor Author

paglias commented Nov 12, 2013

Hopefully this pull request will be merged in 1.2.1 angular/angular.js#4859

@paglias
Copy link
Contributor Author

paglias commented Nov 15, 2013

@lefnire
Copy link
Contributor

lefnire commented Nov 16, 2013

Wooo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants