Page Weight 2021 edits #2603
Merged
Page Weight 2021 edits #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
added
ASAP
|
Thanks a million @tunetheweb. I appreciate it all your help as well as @siakaramalegos. |
logicalphase
approved these changes
Nov 28, 2021
There was a problem hiding this comment.
LGTM - Thank you @tunetheweb, @siakaramalegos, and @RMHolmlund for the outstanding review and editing recommendations.
|
@tunetheweb - all recommendations and edits approved to merge. Thank you. |
tunetheweb
added a commit
that referenced
this pull request
Nov 28, 2021
* Page Weight Markdown * Add contributors * Add images * Remove duplicate contributor * Final Draft Editing Pass Removed todo list atop the page, and did some editing for the final draft. The chapter is ready for Sia to review and Rebecca for final editing. * Replaced username with full name * Update src/content/en/2021/page-weight.md Co-authored-by: Sia <[email protected]> * Update src/content/en/2021/page-weight.md Co-authored-by: Sia <[email protected]> * Update src/content/en/2021/page-weight.md Co-authored-by: Sia <[email protected]> * Update src/content/en/2021/page-weight.md Co-authored-by: Sia <[email protected]> * Update src/content/en/2021/page-weight.md Will add additional link to support energy usage in data centers. JT Co-authored-by: Sia <[email protected]> * Update src/content/en/2021/page-weight.md Co-authored-by: Sia <[email protected]> * Slimmed down and refactored closing paragraphs * Page Weight 2021 edits (#2603) * Page Weight 2021 edits * Spelling and grammar check * Set back TODO until launch Co-authored-by: John Teague <[email protected]> Co-authored-by: Sia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@logicalphase I had quite a bit of feedback on #2517, including an editing pass, so instead of commenting on that PR, I've proposed a PR to that PR.
I've also incorporated @siakaramalegos 's outstanding feedback, and added one graph and query to address some of that feedback that I thought was relevant.
I've restaged this version of the chapter here: https://20211128t175821-dot-webalmanac.uk.r.appspot.com/en/2021/page-weight
If you're happy with these edits, then we can merge this into your PR, and then merge that PR and we're done.