Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #3097] Fix analytics deploy not having a CDN #3590

Merged
merged 1 commit into from
Jan 21, 2025
Merged

[Issue #3097] Fix analytics deploy not having a CDN #3590

merged 1 commit into from
Jan 21, 2025

Conversation

coilysiren
Copy link
Collaborator

@coilysiren coilysiren commented Jan 21, 2025 •
edited
Loading

Summary

Accidentally caused by work on #3097

Time to review: 1 mins

Changes proposed

Gaurds against the cause where a given service doesn't have a CDN to deploy (which is only analytics right now)

Testing

Analytics deploy was broken before this change, and now it's not. I haven't tested API and frontend, but I'm hoping this doesn't break them.

@coilysiren coilysiren mentioned this pull request Jan 21, 2025
Merged
@coilysiren coilysiren changed the title Fix analytics deploy not having a CDN [Issue #3097] Fix analytics deploy not having a CDN Jan 21, 2025
@coilysiren coilysiren marked this pull request as ready for review January 21, 2025 18:09
mdragon
mdragon approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@mdragon mdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@coilysiren coilysiren merged commit 044a741 into main Jan 21, 2025
6 checks passed
@coilysiren coilysiren deleted the kai/ana-cdn branch January 21, 2025 18:43
coilysiren added a commit that referenced this pull request Jan 21, 2025
@coilysiren
[Issue #3160] Fix analytics access to the API => Analytics bucket (#3589
d72dd75 
)

## Summary

Relates to #3160

### Time to review: __1 mins__

## Changes proposed

I put this particular IAM permission in the wrong place, I'm fairly sure

## Testing

I cant test this right now because I'm being blocked by
#3590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdragon mdragon mdragon approved these changes

@acouch acouch Awaiting requested review from acouch acouch is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coilysiren @mdragon