Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #3160] Fix analytics access to the API => Analytics bucket #3589

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

coilysiren
Copy link
Collaborator

@coilysiren coilysiren commented Jan 21, 2025

Summary

Relates to #3160

Time to review: 1 mins

Changes proposed

I put this particular IAM permission in the wrong place, I'm fairly sure

Testing

I cant test this right now because I'm being blocked by #3590

@coilysiren coilysiren changed the title analytics transfer bucket access Fixes granting analytics access to the API => Analytics transfer bucket Jan 21, 2025
@coilysiren coilysiren changed the title Fixes granting analytics access to the API => Analytics transfer bucket Fix analytics access to the API => Analytics transfer bucket Jan 21, 2025
@coilysiren coilysiren changed the title Fix analytics access to the API => Analytics transfer bucket [Issue #3160] Fix analytics access to the API => Analytics transfer bucket Jan 21, 2025
@coilysiren coilysiren marked this pull request as ready for review January 21, 2025 18:10
@coilysiren coilysiren changed the title [Issue #3160] Fix analytics access to the API => Analytics transfer bucket [Issue #3160] Fix analytics access to the API => Analytics bucket Jan 21, 2025
Copy link
Collaborator

@mdragon mdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coilysiren coilysiren merged commit d72dd75 into main Jan 21, 2025
6 checks passed
@coilysiren coilysiren deleted the kai/ana-trans branch January 21, 2025 18:43
coilysiren added a commit that referenced this pull request Jan 21, 2025
## Summary

Relates to #3160

### Time to review: __1 mins__

## Context for reviewers

#3589 was half done, this
PR finishes it

## Testing

I've deployed this to make sure the infra works. I tested the step
function and:

<img width="1318" alt="image"
src="https://github.com/user-attachments/assets/dc25faed-c2dd-4a5e-af4a-bced51ed2abd"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants