Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove selective e2e test skips for webkit #2449

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Remove selective e2e test skips for webkit #2449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d3bba5
Remove test skips for webkit, they pass now
emilycnava Oct 10, 2024
29ef993
remove unused params
emilycnava Oct 10, 2024
1755e21
prettier format fix
emilycnava Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions frontend/tests/e2e/search/search-loading.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,7 @@ test.describe("Search page tests", () => {
await page.goto("/search?_ff=showSearchV0:true");
});

test("should show and hide loading state", async ({
page,
browserName,
}: PageProps) => {
// TODO (Issue #2005): fix test for webkit
test.skip(
browserName === "webkit",
"Skipping test for WebKit due to a query param issue.",
);
test("should show and hide loading state", async ({ page }: PageProps) => {
const searchTerm = "advanced";
await fillSearchInputAndSubmit(searchTerm, page);

Expand Down
7 changes: 0 additions & 7 deletions frontend/tests/e2e/search/search-no-results.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,7 @@ test.describe("Search page tests", () => {

test("should return 0 results when searching for obscure term", async ({
page,
browserName,
}: PageProps) => {
// TODO (Issue #2005): fix test for webkit
test.skip(
browserName === "webkit",
"Skipping test for WebKit due to a query param issue.",
);

const searchTerm = "0resultearch";

await fillSearchInputAndSubmit(searchTerm, page);
Expand Down
Loading