Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove selective e2e test skips for webkit #2449

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Remove selective e2e test skips for webkit #2449

merged 3 commits into from
Oct 15, 2024

Conversation

emilycnava
Copy link
Contributor

Summary

Fixes #2005

Time to review: <10min

Changes proposed

  • Remove e2e test skips for webkit, the test appear to pass now, presumably as a result of search refactoring that previously happened.

Context for reviewers

  • Checkout branch locally and run webkit e2e tests to verify they pass.

Additional information

Screenshot 2024-10-10 at 1 22 02 PM

@acouch acouch merged commit c49832c into HHS:main Oct 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acouch acouch acouch approved these changes

@andycochran andycochran Awaiting requested review from andycochran andycochran is a code owner

@doug-s-nava doug-s-nava Awaiting requested review from doug-s-nava doug-s-nava is a code owner

Assignees
No one assigned
Labels
frontend typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webkit/safari e2e test doesn't update search term query param`
2 participants
@emilycnava @acouch