[Issue #1886]: Fix duplicate id bug in SearchFilterAccordion #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 83.89% | 854/1018 |
| 🟡 | Branches | 64.9% | 220/339 |
| 🟡 | Functions | 75.34% | 165/219 |
| 🟢 | Lines | 83.89% | 797/950 |
Test suite run success
166 tests passing in 55 suites.
Report generated by 🧪jest coverage report action from 06bacc0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1886
Time to review: 1 min
Changes proposed
Context for reviewers
We had duplicate id's for each accordion div - so just append the specific query param key that we use to the id
the remaining Lighthouse a11y issue is due to the
<span>...</span>that's in the component (only<li>tags are allowed inside<ul>) . But this is the USWDS implementation so I'm not sure if we can get around that bug?Additional information
Lighthouse doesn't have this error anymore: