Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Bug: Duplicate IDs in Search Page #1886

Closed
1 task
acouch opened this issue Apr 30, 2024 · 0 comments · Fixed by #1924
Closed
1 task

[Task]: Bug: Duplicate IDs in Search Page #1886

acouch opened this issue Apr 30, 2024 · 0 comments · Fixed by #1924
Assignees
@rylew1
Labels
project: grants.gov Grants.gov Modernization tickets refinement

Comments

@acouch
Copy link
Collaborator

acouch commented Apr 30, 2024

Summary

The following was snagged by Lighthouse:
image

IDs should be unique, this task is to enforce unique IDs on the search page.

Acceptance criteria

  • IDs unique on search page
@acouch acouch added the project: grants.gov Grants.gov Modernization tickets label Apr 30, 2024
@acouch acouch added this to the Search UI - Enhancements and fast follow milestone Apr 30, 2024
@sumiat sumiat moved this from Icebox to Sprint Ready in Simpler.Grants.gov Product Backlog Apr 30, 2024
@rylew1 rylew1 mentioned this issue May 5, 2024
Merged
@rylew1 rylew1 moved this from Sprint Ready to In Progress in Simpler.Grants.gov Product Backlog May 5, 2024
@rylew1 rylew1 moved this from In Progress to In Review in Simpler.Grants.gov Product Backlog May 5, 2024
@rylew1 rylew1 self-assigned this May 5, 2024
rylew1 added a commit that referenced this issue May 6, 2024
@rylew1
[Issue #1886]: Fix duplicate id bug in SearchFilterAccordion (#1924)
17bb7fb 
## Summary
Fixes #1886 

## Changes proposed
- add the query param key to the end of the accordion id to prevent duplicate id a11y issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rylew1 rylew1

Labels
project: grants.gov Grants.gov Modernization tickets refinement
Projects
Simpler.Grants.gov Product Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue #1886]: Fix duplicate id bug in SearchFilterAccordion HHS/simpler-grants-gov
2 participants
@acouch @rylew1