Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #1835] Remove distinct from inner query of search #1836

Merged
merged 2 commits into from
Apr 25, 2024
Merged

[Issue #1835] Remove distinct from inner query of search #1836

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe4cc87
[Issue #1835] Remove distinct from inner query of search
chouinar Apr 25, 2024
4f08921
Merge branch 'main' into chouinar/db-perf-distinct-remove
chouinar Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions api/src/services/opportunities_v0_1/search_opportunities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def search_opportunities(
a set of opportunity IDs for the outer query to filter against. This query
ends up looking like (varying based on exact filters):

SELECT DISTINCT
SELECT
opportunity.opportunity_id
FROM opportunity
JOIN current_opportunity_summary ON opportunity.opportunity_id = current_opportunity_summary.opportunity_id
Expand All @@ -220,9 +220,6 @@ def search_opportunities(
) # Only ever return non-drafts
# Filter anything without a current opportunity summary
.where(Opportunity.current_opportunity_summary != None) # noqa: E711
# Distinct the opportunity IDs returned so that the outer query
# has fewer results to query against
.distinct()
)

# Current + Opportunity Summary are always needed so just add them here
Expand Down
Loading