[Issue #1835] Remove distinct from inner query of search #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
requested review from
acouch,
aplybeah and
SammySteiner
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1835
Time to review: 3 mins
Changes proposed
Adjust the search query to not do
distincton the inner filter queryContext for reviewers
This distinct originally was added as the query was setup in a much different way. We needed to do the distinct to avoid duplicates when doing joins, but because it is now an inner query - quite literally used as
select ... where opportunity_id in (select distinct opportunity_id ...)we don't need to distinct it. If the values aren't distinct, it doesn't actually change the outer query, there will just be dupes in that list, but that's fine and seems to be better performing.