Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nucal calibrator class #920

Merged
merged 62 commits into from
Feb 7, 2024
Merged

Add nucal calibrator class #920

Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
abc27d4
Add optax library for gradient descent
tyler-a-cox Apr 11, 2023
21da29a
Add fitting functions for gradient descent
tyler-a-cox Apr 11, 2023
4f8751a
Add gradient descent functions
tyler-a-cox Nov 7, 2023
54955df
Add optimization class
tyler-a-cox Nov 7, 2023
60db19f
Add main optimization loop
tyler-a-cox Nov 8, 2023
20930e9
Add additional functionality to nucal
tyler-a-cox Nov 8, 2023
39092d4
Merge branch 'main' into nucal_optimization
tyler-a-cox Nov 15, 2023
1edeb96
Separate computed model_components
tyler-a-cox Nov 15, 2023
dc7cb82
More documentation
tyler-a-cox Nov 15, 2023
4456044
Change name of conv_crit
tyler-a-cox Nov 15, 2023
ffe0532
Fix convergence criteria error
tyler-a-cox Nov 15, 2023
7b91122
Fix compute_filters function
tyler-a-cox Nov 16, 2023
f44310c
Remove old keyword
tyler-a-cox Nov 16, 2023
26abc8f
Use correct filters
tyler-a-cox Nov 16, 2023
f3a27c9
Replace keyword arguments
tyler-a-cox Nov 16, 2023
9edc52b
Add documentation for new parameters
tyler-a-cox Nov 16, 2023
02f1275
Fill in missing docs
tyler-a-cox Nov 16, 2023
e48c48e
Add additional return option
tyler-a-cox Nov 16, 2023
031457c
Include tests for calibration class
tyler-a-cox Nov 16, 2023
3dcdecb
Include per gradient descent degen estimation
tyler-a-cox Nov 17, 2023
b72aa4e
Reformulate degen estimation
tyler-a-cox Nov 17, 2023
49edefa
Write a test for foreground model
tyler-a-cox Nov 17, 2023
408b54f
Add tests for gradient descent functions
tyler-a-cox Nov 18, 2023
79f6165
Finalize gradient descent tests
tyler-a-cox Nov 18, 2023
a34c879
Add optax to install_requires
tyler-a-cox Nov 18, 2023
143fc45
Add additional documentation
tyler-a-cox Nov 28, 2023
fdceb39
Docstring for nucal calibrate function
tyler-a-cox Nov 28, 2023
4f4c8b0
Cut the minor loss function for simplicity
tyler-a-cox Nov 28, 2023
4c5fe8d
Add docstring to SpectrallyRedundantCalibrator
tyler-a-cox Nov 28, 2023
fa905fa
Make changes from PR comments
tyler-a-cox Nov 29, 2023
da70a35
Modify tests
tyler-a-cox Nov 29, 2023
a21a65b
doc updates
tyler-a-cox Dec 5, 2023
c6262f3
add test for post_redcal_nucal
tyler-a-cox Dec 11, 2023
6fcfb5d
Merge branch 'main' into nucal_optimization
tyler-a-cox Dec 11, 2023
7042c41
Remove optional import of optax
tyler-a-cox Dec 15, 2023
3c02e14
Clarify documentation
tyler-a-cox Dec 20, 2023
df130f8
Store minor cycle losses with major cycle losses
tyler-a-cox Dec 20, 2023
3ebdb78
clarify major/minor cycles docstring
tyler-a-cox Dec 20, 2023
a711b5c
Simplify _compute_filters logic
tyler-a-cox Jan 12, 2024
0a60842
Set random seed for testing
tyler-a-cox Jan 12, 2024
dbadac6
Fix documentation
tyler-a-cox Jan 12, 2024
55a2dc3
update variable name in tests
tyler-a-cox Jan 12, 2024
435f8e6
add missing parameter
tyler-a-cox Jan 12, 2024
005a7ec
improve testing accuracy of gain est
tyler-a-cox Jan 22, 2024
08e791a
fix estimation of degenerate parameters
tyler-a-cox Jan 24, 2024
b0e71db
fix params typo
tyler-a-cox Feb 1, 2024
a509e52
changed default optimizer
tyler-a-cox Feb 5, 2024
dcf2430
fix tests
tyler-a-cox Feb 5, 2024
3712883
Merge branch 'main' into nucal_optimization
tyler-a-cox Feb 5, 2024
523f497
revert optax to work for py3.8
tyler-a-cox Feb 5, 2024
634b476
revert commit
tyler-a-cox Feb 5, 2024
91e0d36
lock optax version to work with python 3.8
tyler-a-cox Feb 5, 2024
47590a7
package typo
tyler-a-cox Feb 5, 2024
8135aac
clarified cal_flags in docstring
tyler-a-cox Feb 6, 2024
93bc8c9
added minor losses to total loss array
tyler-a-cox Feb 6, 2024
f8949cb
fix typo in calibration loop
tyler-a-cox Feb 6, 2024
b9c0b51
Merge branch 'main' into nucal_optimization
jsdillon Feb 6, 2024
306da1b
add document of regularization parameter + change default
tyler-a-cox Feb 6, 2024
5554363
change reg "tol" parameter to "alpha"
tyler-a-cox Feb 6, 2024
f93b3cd
unlock optax version
tyler-a-cox Feb 6, 2024
5de9117
add newline to test file
tyler-a-cox Feb 6, 2024
259f4e7
filter out smaller groups in test case
tyler-a-cox Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading