Add nucal calibrator class #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
========================================
Coverage 97.15% 97.16%
========================================
Files 23 23
Lines 10520 10638 +118
========================================
+ Hits 10221 10336 +115
- Misses 299 302 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsdillon
reviewed
Feb 6, 2024
jsdillon
reviewed
Feb 6, 2024
jsdillon
reviewed
Feb 6, 2024
jsdillon
approved these changes
Feb 6, 2024
| gradient descent steps. | ||
| spectral_filter_half_width : float, default=20e-9 | ||
| Fourier half-width of the spectral axis DPSS filters in units of seconds. | ||
| spatial_filter_half_width : float, default=1 |
| class TestGradientDescent: | ||
| def setup_method(self): | ||
| self.freqs = np.linspace(50e6, 250e6, 200) | ||
| self.antpos = linear_array(10, sep=2) |
There was a problem hiding this comment.
As a compromise, let's do two linear arms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new class,
SpectrallyRedundantCalibrator, for calibrating spatially redundant degeneracies using spectrally redundant calibration. This class uses gradient descent to solve for a smooth DPSS-based, sky model and redundant baseline degeneracies using the method detailed here and is intended to be an easy-to-use implementation of spectrally redundant calibration, likeredcal.RedundantCalibratoris for spatially redundant calibration.