-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduces overly-pedantic casting in the public headers #644
Merged
lrknox
merged 32 commits into
HDFGroup:develop
from
derobins:minor/reduce_pedantic_public_casting
May 15, 2021
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
ba9deae
Committing clang-format changes
github-actions[bot] 00f9750
Merge remote-tracking branch 'canonical/develop' into develop
derobins e997283
Merge remote-tracking branch 'canonical/develop' into develop
derobins 3eac585
Merge remote-tracking branch 'canonical/develop' into develop
derobins 71643b7
Merge remote-tracking branch 'canonical/develop' into develop
derobins d242911
Merge remote-tracking branch 'canonical/develop' into develop
derobins bc70f95
Merge remote-tracking branch 'canonical/develop' into develop
derobins 3d7ad8e
Merge remote-tracking branch 'canonical/develop' into develop
derobins aeb16b7
Merge branch 'develop' of https://github.com/derobins/hdf5 into develop
derobins 765cb5b
Merge remote-tracking branch 'canonical/develop' into develop
derobins 18401fc
Merge remote-tracking branch 'canonical/develop' into develop
derobins 222242c
Merge branch 'develop' of https://github.com/derobins/hdf5 into develop
derobins 8d0cafa
Merge remote-tracking branch 'canonical/develop' into develop
derobins d3694d1
Merge remote-tracking branch 'canonical/develop' into develop
derobins 1c7bcc2
Merge remote-tracking branch 'canonical/develop' into develop
derobins 70551e3
Merge remote-tracking branch 'canonical/develop' into develop
derobins 2dfc7db
Merge remote-tracking branch 'canonical/develop' into develop
derobins 71d2fbf
Merge remote-tracking branch 'canonical/develop' into develop
derobins c8925f8
Merge remote-tracking branch 'canonical/develop' into develop
derobins dd3e970
Merge branch 'develop' of https://github.com/derobins/hdf5 into develop
derobins bb61990
Merge remote-tracking branch 'canonical/develop' into develop
derobins 2c2b368
Merge remote-tracking branch 'canonical/develop' into develop
derobins be2ada6
Merge remote-tracking branch 'canonical/develop' into develop
derobins 439f3a8
Merge remote-tracking branch 'canonical/develop' into develop
derobins 649aa9b
Merge remote-tracking branch 'canonical/develop' into develop
derobins 3fa627f
Merge remote-tracking branch 'canonical/develop' into develop
derobins 0df36ec
Merge remote-tracking branch 'canonical/develop' into develop
derobins d65c841
Merge remote-tracking branch 'canonical/develop' into develop
derobins fc7eb21
Merge branch 'develop' of https://github.com/derobins/hdf5 into develop
derobins 130d491
Merge remote-tracking branch 'canonical/develop' into develop
derobins 544b320
Merge remote-tracking branch 'canonical/develop' into develop
derobins 0fecdf6
Fixes overly pedantic casting in public headers
derobins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ | |
/*****************/ | ||
|
||
/* Default value for "no event set" / synchronous execution */ | ||
#define H5ES_NONE (hid_t)0 | ||
#define H5ES_NONE 0 /* (hid_t) */ | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I left the type in a comment so that the integer is less of a magic number. |
||
/* Special "wait" timeout values */ | ||
#define H5ES_WAIT_FOREVER (UINT64_MAX) /* Wait until all operations complete */ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Casting -1 to an unsigned integral type is an unnatural subversion of the type system and unnecessary. It's more intentional to use SIZE_MAX, etc.