Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename HDoff_t to hoff_t #5065

Closed
wants to merge 2 commits into from
Closed

Conversation

derobins
Copy link
Member

@derobins derobins commented Nov 4, 2024

hoff_t is in line with the other typedefs in H5public.h (hsize_t, etc.).

derobins and others added 2 commits November 4, 2024 00:25
hoff_t is in line with the other typedefs in H5public.h (hsize_t, etc.).
@derobins derobins added Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - C Library Core C library issues (usually in the src directory) Component - Tools Command-line tools like h5dump, includes high-level tools Component - Java Java wrappers Component - Fortran Fortran wrappers Component - C++ C++ wrappers Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality labels Nov 4, 2024
@derobins derobins mentioned this pull request Nov 4, 2024
Copy link
Contributor

@qkoziol qkoziol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with the revised naming. The HDoff_t indicates that it's for portability betweens OS platforms' offset types. The 'hsize_t', haddr_t', etc. are HDF5-specific types and don't have anything to do with OS platforms. I believe that HDoff_t (and other platform portability types & function) should stay distinct from the HDF5 types.

@derobins
Copy link
Member Author

derobins commented Nov 4, 2024

I disagree with the revised naming. The HDoff_t indicates that it's for portability betweens OS platforms' offset types. The 'hsize_t', haddr_t', etc. are HDF5-specific types and don't have anything to do with OS platforms. I believe that HDoff_t (and other platform portability types & function) should stay distinct from the HDF5 types.

hsize_t is basically a platform-independent size. hbool_t was a platform-independent Boolean before bool was a standard.

@derobins
Copy link
Member Author

derobins commented Nov 4, 2024

I'm going to turn that H5Pset/get_external() parameter into a haddr_t so we don't have to expose a platform-independent off_t. HDoff_t will go back into H5private.h, where it belongs.

@derobins derobins closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - C Library Core C library issues (usually in the src directory) Component - C++ C++ wrappers Component - Fortran Fortran wrappers Component - Java Java wrappers Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Component - Tools Command-line tools like h5dump, includes high-level tools Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants