-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename HDoff_t to hoff_t #5065
Rename HDoff_t to hoff_t #5065
Conversation
hoff_t is in line with the other typedefs in H5public.h (hsize_t, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with the revised naming. The HDoff_t indicates that it's for portability betweens OS platforms' offset types. The 'hsize_t', haddr_t', etc. are HDF5-specific types and don't have anything to do with OS platforms. I believe that HDoff_t (and other platform portability types & function) should stay distinct from the HDF5 types.
hsize_t is basically a platform-independent size. hbool_t was a platform-independent Boolean before bool was a standard. |
I'm going to turn that H5Pset/get_external() parameter into a haddr_t so we don't have to expose a platform-independent off_t. HDoff_t will go back into H5private.h, where it belongs. |
hoff_t is in line with the other typedefs in H5public.h (hsize_t, etc.).