Update stdio API calls #5064
Merged
Update stdio API calls #5064
+33
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stdio VFD set up ftell, etc. equivalents differently than the rest of the library. This PR aligns them with H5private.h and H5win32defs.h and should fix some issues with MinGW. The stdio VFD now also uses HDoff_t, which will be a public symbol in the next major release of HDF5. In the main library, HDftell was set to be ftell and not ftello. This probably isn't a big deal since the systems where it's used all have 64-bit longs, but we should match types correctly.
derobins
added
Priority - 2. Medium ⏹
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
derobins
added
Type - Bug / Bugfix
|
NOTE: If this is merged to a future 1.14.6 release, HDoff_t will have to be replaced with a restored file_offset_t. |
|
NOTE NOTE: This PR will need to be updated after #5065 goes in. |
byrnHDF
approved these changes
Nov 4, 2024
qkoziol
approved these changes
Nov 4, 2024
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Nov 4, 2024
The stdio VFD set up ftell, etc. equivalents differently than the rest of the library. This PR aligns them with H5private.h and H5win32defs.h and should fix some issues with MinGW. The stdio VFD now also uses HDoff_t, which will be a public symbol in the next major release of HDF5. In the main library, HDftell was set to be ftell and not ftello. This probably isn't a big deal since the systems where it's used all have 64-bit longs, but we should match types correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stdio VFD set up ftell, etc. equivalents differently than the rest of the library. This PR aligns them with H5private.h and H5win32defs.h and should fix some issues with MinGW. The stdio VFD now also uses HDoff_t, which will be a public symbol in the next major release of HDF5.
In the main library, HDftell was set to be ftell and not ftello. This probably isn't a big deal since the systems where it's used all have 64-bit longs, but we should match types correctly.