Update h5fc.in missed line for libhdf5hl_fortran filename change to libhdf5_hl_fortran. #4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_fortran to be consistent with CMake install and with other hl lib files. Switched corresponding symlink to libhdf5hl_fortran. Fixes issue HDFGroup#4684.
Fix typo in code to create link to libhdf5_hl_fortran.a.
libhdf5hl_fortran. Add RELEASE.txt entry about changeing name libhdf5hl_fortran to libhdf5_hl_fortran.
libhdf5_hl_fortran. Fixes check-install failure.
lrknox
requested review from
brtnfld,
derobins,
epourmal,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09 and
mattjala
as code owners
…h_libhdf5hl_fortran.so_file_and_link
glennsong09
approved these changes
Sep 13, 2024
mattjala
approved these changes
Sep 13, 2024
byrnHDF
approved these changes
Sep 13, 2024
lrknox
added
Merge - Develop Only
derobins
approved these changes
Sep 16, 2024
lrknox
added
Merge - To 1.14
and removed
Merge - Develop Only
lrknox
added a commit
to lrknox/hdf5
that referenced
this pull request
Oct 2, 2024
…ibhdf5_hl_fortran. (HDFGroup#4831) * Change name of libhdf5hl_fortran installed by autotools to libhdf5_hl_fortran to be consistent with CMake install and with other hl lib files. Switched corresponding symlink to libhdf5hl_fortran. Fixes issue HDFGroup#4684. * Update h5fc.in to use renamed libhdf5_hl_fortran. Fix typo in code to create link to libhdf5_hl_fortran.a. * Removed code to create symlink for previous name of renamed lib libhdf5hl_fortran. Add RELEASE.txt entry about changeing name libhdf5hl_fortran to libhdf5_hl_fortran. * Update missed line in h5fc.in for libhdf5hl_fortran name change to libhdf5_hl_fortran. Fixes check-install failure.
lrknox
added a commit
that referenced
this pull request
Oct 2, 2024
…ibhdf5_hl_fortran. (#4831) * Change name of libhdf5hl_fortran installed by autotools to libhdf5_hl_fortran to be consistent with CMake install and with other hl lib files. Switched corresponding symlink to libhdf5hl_fortran. Fixes issue #4684. * Update h5fc.in to use renamed libhdf5_hl_fortran. Fix typo in code to create link to libhdf5_hl_fortran.a. * Removed code to create symlink for previous name of renamed lib libhdf5hl_fortran. Add RELEASE.txt entry about changeing name libhdf5hl_fortran to libhdf5_hl_fortran. * Update missed line in h5fc.in for libhdf5hl_fortran name change to libhdf5_hl_fortran. Fixes check-install failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.