Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent naming of hdf5_hl_fortran library between autotools and CMake build #4684

Closed
jsberg-bnl opened this issue Aug 1, 2024 · 1 comment
Closed

Inconsistent naming of hdf5_hl_fortran library between autotools and CMake build #4684

jsberg-bnl opened this issue Aug 1, 2024 · 1 comment
Assignees
@lrknox
Milestone
2.0.0

Comments

@jsberg-bnl
Copy link

jsberg-bnl commented Aug 1, 2024 •
edited
Loading

Describe the bug
A CMake build will create libraries named libhdf5_hl_fortran.*. The autotools build will instead create libraries named libhdf5hl_fortran.*, then create soft links libhdf5_hl_fortran.so and libhdf5_hl_fortran.a pointing to the corresponding libhdf5hl_fortran.* files. On MacOS, the dynamic library is named libhdf5hl_fortran.dylib, and no corresponding link is made there.

Expected behavior
Both the autotools build and the CMake build should create libraries with the same names, and for hl_fortran, those names should be libhdf5_hl_fortran.*

Platform (please complete the following information)

  • HDF5 version: 1.14.4-3
  • OS and version: Arch fully updated; MacOS 14.5 w/ HomeBrew fully updated
  • Compiler and version: gcc 14.1
  • Build system (e.g. CMake, Autotools) and version: CMake 3.30.1, latest autotools
  • Any configure options you specified: configure: --enable-fortran --enable-cxx --without-szlib --without-zlib; CMake: -G "Unix Makefiles" -DHDF5_BUILD_JAVA=OFF
  • MPI library and version (parallel HDF5): n/a

Additional context
Also see issue #4526, addressing more inconsistencies between the two build methods.
@derobins derobins added this to the 1.16.0 milestone Aug 29, 2024
lrknox added a commit to lrknox/hdf5 that referenced this issue Sep 6, 2024
@lrknox
Change name of libhdf5hl_fortran installed by autotools to libhdf5_hl…
851e09b 
…_fortran to be

consistent with CMake install and with other hl lib files.  Switched
corresponding symlink to libhdf5hl_fortran.
Fixes issue HDFGroup#4684.
@lrknox lrknox mentioned this issue Sep 6, 2024
Merged
derobins pushed a commit that referenced this issue Sep 7, 2024
@lrknox
Change name of libhdf5hl_fortran installed by autotools (#4811)
baa0439 
* Change name of libhdf5hl_fortran installed by autotools to libhdf5_hl_fortran to be
consistent with CMake install and with other hl lib files.  Switched
corresponding symlink to libhdf5hl_fortran.
Fixes issue #4684.

* Update h5fc.in to use renamed libhdf5_hl_fortran.
Fix typo in code to create link to libhdf5_hl_fortran.a.

* Removed code to create symlink for previous name of renamed lib
libhdf5hl_fortran.
Add RELEASE.txt entry about changeing name libhdf5hl_fortran to
libhdf5_hl_fortran.
derobins pushed a commit that referenced this issue Sep 16, 2024
@lrknox
Update h5fc.in missed line for libhdf5hl_fortran filename change to l…
405d1b9 
…ibhdf5_hl_fortran. (#4831)

* Change name of libhdf5hl_fortran installed by autotools to libhdf5_hl_fortran to be
consistent with CMake install and with other hl lib files.  Switched
corresponding symlink to libhdf5hl_fortran.
Fixes issue #4684.

* Update h5fc.in to use renamed libhdf5_hl_fortran.
Fix typo in code to create link to libhdf5_hl_fortran.a.

* Removed code to create symlink for previous name of renamed lib
libhdf5hl_fortran.
Add RELEASE.txt entry about changeing name libhdf5hl_fortran to
libhdf5_hl_fortran.

* Update missed line in h5fc.in for libhdf5hl_fortran name change to
libhdf5_hl_fortran.  Fixes check-install failure.
lrknox added a commit to lrknox/hdf5 that referenced this issue Oct 2, 2024
@lrknox
Update h5fc.in missed line for libhdf5hl_fortran filename change to l…
9e266c7 
…ibhdf5_hl_fortran. (HDFGroup#4831)

* Change name of libhdf5hl_fortran installed by autotools to libhdf5_hl_fortran to be
consistent with CMake install and with other hl lib files.  Switched
corresponding symlink to libhdf5hl_fortran.
Fixes issue HDFGroup#4684.

* Update h5fc.in to use renamed libhdf5_hl_fortran.
Fix typo in code to create link to libhdf5_hl_fortran.a.

* Removed code to create symlink for previous name of renamed lib
libhdf5hl_fortran.
Add RELEASE.txt entry about changeing name libhdf5hl_fortran to
libhdf5_hl_fortran.

* Update missed line in h5fc.in for libhdf5hl_fortran name change to
libhdf5_hl_fortran.  Fixes check-install failure.
lrknox added a commit that referenced this issue Oct 2, 2024
@lrknox
Update h5fc.in missed line for libhdf5hl_fortran filename change to l…
1898564 
…ibhdf5_hl_fortran. (#4831)

* Change name of libhdf5hl_fortran installed by autotools to libhdf5_hl_fortran to be
consistent with CMake install and with other hl lib files.  Switched
corresponding symlink to libhdf5hl_fortran.
Fixes issue #4684.

* Update h5fc.in to use renamed libhdf5_hl_fortran.
Fix typo in code to create link to libhdf5_hl_fortran.a.

* Removed code to create symlink for previous name of renamed lib
libhdf5hl_fortran.
Add RELEASE.txt entry about changeing name libhdf5hl_fortran to
libhdf5_hl_fortran.

* Update missed line in h5fc.in for libhdf5hl_fortran name change to
libhdf5_hl_fortran.  Fixes check-install failure.
@lrknox
Copy link
Collaborator

lrknox commented Oct 23, 2024

Names corrected to be libhdf5_hl_fortran.* in develop, will be in next release (2.0.0).

@lrknox lrknox closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrknox lrknox

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@derobins @lrknox @jsberg-bnl