Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync develop changes July 29 - August 21 to hdf5_1_14. #4742

Merged
merged 31 commits into from
Aug 22, 2024
Merged

Sync develop changes July 29 - August 21 to hdf5_1_14. #4742

merged 31 commits into from
Aug 22, 2024

Conversation

lrknox
Copy link
Collaborator

@lrknox lrknox commented Aug 21, 2024

No description provided.

brtnfld and others added 30 commits August 21, 2024 14:35
@brtnfld @lrknox
Warning fix (HDFGroup#4682)
e27be15 
* warning fix

* warning fix
@byrnHDF @lrknox
CMake link line needs to use new HDF5_ENABLE_THREADS (HDFGroup#4685)
51e0b37
@byrnHDF @lrknox
Correct the properties for using THREADS library (HDFGroup#4690)
5f249e6
@dependabot @lrknox
Bump the github-actions group with 5 updates (HDFGroup#4688)
8427aec 
Bumps the github-actions group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [actions/download-artifact](https://github.com/actions/download-artifact) | `4.1.7` | `4.1.8` |
| [DoozyX/clang-format-lint-action](https://github.com/doozyx/clang-format-lint-action) | `0.13` | `0.17` |
| [softprops/action-gh-release](https://github.com/softprops/action-gh-release) | `2.0.6` | `2.0.8` |
| [ossf/scorecard-action](https://github.com/ossf/scorecard-action) | `2.3.3` | `2.4.0` |
| [github/codeql-action](https://github.com/github/codeql-action) | `3.25.11` | `3.25.15` |


Updates `actions/download-artifact` from 4.1.7 to 4.1.8
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@65a9edc...fa0a91b)

Updates `DoozyX/clang-format-lint-action` from 0.13 to 0.17
- [Release notes](https://github.com/doozyx/clang-format-lint-action/releases)
- [Commits](DoozyX/clang-format-lint-action@v0.13...v0.17)

Updates `softprops/action-gh-release` from 2.0.6 to 2.0.8
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](softprops/action-gh-release@a74c6b7...c062e08)

Updates `ossf/scorecard-action` from 2.3.3 to 2.4.0
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](ossf/scorecard-action@dc50aa9...62b2cac)

Updates `github/codeql-action` from 3.25.11 to 3.25.15
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@b611370...afb54ba)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
- dependency-name: DoozyX/clang-format-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
- dependency-name: softprops/action-gh-release
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
...
@jhendersonHDF @lrknox
Fix segfault when closing datatype during failure in H5Topen2 (HDFGro…
23f69e4 
…up#4683)
@byrnHDF @lrknox
Rework Dynamic Analysis and sanitize testing (HDFGroup#4681)
71654ab 
* Ignore predetermined failing test and check pointer before use

* Rework Analysis process
@qkoziol @lrknox
Remove another H5E_BEGIN/END_TRY within the library (HDFGroup#4675)
cc77b95 
* Update logic for (deprecated) H5Gget_objinfo() call to eliminate H5E_BEGIN_TRY

* Handle case for '.' at the end of a path
@qkoziol @lrknox
Drop H5E_BEGIN/END_TRY and just check the error return from H5I_clear…
11fb3a4 
…_types() (HDFGroup#4694)

Original case that the change in commit 2dc738a
no longer applies.
@bmribler @lrknox
Add check of returned value from API calls. (HDFGroup#4702)
9e23b2a 
These were found while investigating HDFGroupGH-4672, but they were not related
to HDFGroupGH-4672.
@byrnHDF @lrknox
Add mac dmg binary and remove old macos-13 workflows (HDFGroup#4699)
360a6df
@byrnHDF @lrknox
Add Windows SHLWAPI lib to public interface (HDFGroup#4701)
11fe4e5
@byrnHDF @lrknox
Use local variable in btree2 and print value (HDFGroup#4679)
3cc6ffb 
* Correct logic

* Technically, level 1 Express could skip tests
@byrnHDF @lrknox
Add windows signing (HDFGroup#4703)
f886150
@bmribler @lrknox
Add tests for H5R get name APIs (HDFGroup#4657)
8dc2981 
Added functionality tests for the following APIs:
H5Rget_file_name
H5Rget_obj_name
H5Rget_attr_name

Also removed "+1" when returning a name length in H5R__get_attr_name().
The exter "+1" gave an incorrect value for the length of the referenced
object's attribute name.

Fixed HDFGroupGH-4447

* Fix Fortran test

The C API H5Rget_attr_name incorrectly added 1 to the length of the
referenced object's attribute name, so the Fortran API h5rget_attr_name_f
removed 1 from the returned value to accommodate the incorrectness.
This PR fixes H5Rget_attr_name so this workaround in h5rget_attr_name_f
is no longer needed.

* Add test H5Aget_name against H5Rget_attr_name
@hyoklee @lrknox
Replace Visual Studio ???? with 2022 in MSI README file (HDFGroup#4709)
cb08ded
@byrnHDF @lrknox
Change logic for checking secrets exists (HDFGroup#4711)
37ce02b
@byrnHDF @lrknox
Change osx refs to macos (HDFGroup#4707)
fd56956
@bmribler @lrknox
Replace alias \Code with \TText (HDFGroup#4714)
d680c72 
Fixed HDFGroupGH-2151
@byrnHDF @lrknox
Correct signing names and variables (HDFGroup#4713)
2df0159
@byrnHDF @lrknox
Add secrets to release workflow (HDFGroup#4719)
66e963a
@byrnHDF @lrknox
Add missing blosc2 info (HDFGroup#4717)
0a8fa15
@derobins @lrknox
Fix error return types in H5Rdeprec.c (HDFGroup#4722)
4c93adc 
Copy-pasted code from elsewhere used FAIL instead of H5G_UNKNOWN
and H5I_INVALID_HID.
@byrnHDF @lrknox
Fix the release reference name (HDFGroup#4721)
ff7a1a0
@mattjala @lrknox
Test creating unseekable file (HDFGroup#4720)
a80f976
@bmribler @lrknox
Cleanup up tests (HDFGroup#4724)
e969e92
@hyoklee @lrknox
Add arch name to dmg file name (HDFGroup#4732)
d17c84b 
The binaries in snapshot dmg file do not work on x86_64.
@hyoklee @lrknox
Fix snapshot CI failure by adding arch name to dmg file (HDFGroup#4734)
8d55a26 
See also HDFGroup#4732.
@bmribler @lrknox
Fix incorrect VOL vs. non-VOL calls partially (HDFGroup#4733)
deffa57 
* Fix incorrect VOL vs. non-VOL calls

H5Lget_info2() called H5I_object() instead of H5VL_vol_object() crashed
user application.
This is a wide-spread issue (HDFGroupGH-4730) but this PR only addresses HDFGroupGH-4705.

* Remove an incorrect change
@mattjala @lrknox
Fix segfault in ROS3 credential parsing (HDFGroup#4736)
51f6aac 
* Fix segfault in s3 credential parsing

* Fix AWS cred parsing when >1 profile provided
@hyoklee @lrknox
Revert gh-pages action hash to fix daily build (HDFGroup#4735)
c645e50 
* Revert gh-pages action hash to fix daily build

See also HDFGroup#4734

* Revert gh-pages action hash to fix daily build
@qkoziol @lrknox
Eliminate another use of H5E_clear_stack() within the library (HDFGro…
3cf744a 
…up#4726)

* Remove call to H5E_clear_stack()

Also clean up a bunch of error macros and the return value from H5B_valid()
@lrknox lrknox marked this pull request as ready for review August 22, 2024 12:35
@lrknox lrknox merged commit 13a9a82 into HDFGroup:hdf5_1_14 Aug 22, 2024
56 checks passed
@lrknox lrknox deleted the sync_develop_changes_to_1_14 branch August 27, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrnHDF byrnHDF byrnHDF approved these changes

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@epourmal epourmal Awaiting requested review from epourmal epourmal is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lrknox @byrnHDF @brtnfld @jhendersonHDF @qkoziol @bmribler @hyoklee @derobins @mattjala