feat: Remove erronous? lock to x86_64-linux #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemonsy
commented
Jan 11, 2022
| @@ -28,7 +28,7 @@ Gem::Specification.new do |spec| | |||
|
|
|||
| spec.add_dependency 'graphql', '>= 1.9.8' | |||
|
|
|||
| spec.add_runtime_dependency 'google-protobuf', '~> 3.7' | |||
| spec.add_runtime_dependency 'google-protobuf', '~> 3.13.0' | |||
There was a problem hiding this comment.
Wanted to only keep the minor to 3.13 since this PR is only about removing the platform lock.
Also guessing typically if we wanted to lock versions, having it locked to patch and having the maintainers manually bump minor/major versions is more intention revealing.
|
Kudos to @toreriklinnerud for debugging this with me. More context, bundler 2.20 introduced the specific platform locking and may have contributed to this. For more context: |
daemonsy
changed the title
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's up?
Hoping this will resolve #144 , where it seems like folks using M1 might have issue with the platform being forced to use the linux binary. Also updates bundler to the latest/greatest, which keeps turning up when you search for M1 compatibility issues, though not directly related to this one.
Hopefully the bundler update accounts for the fact there are multiple mac platform types better.
This platform change was introduced by semantic release bot in 631ebfe#diff-89cade48462044ee1b672dc5f4c3ec250fbd29effcd8932096a23c1283c6731fR44 which could be a bundler bug 🤷