refactor: drop support of physical plan query interface #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #714 +/- ##
=========================================
Coverage 86.03% 86.03%
=========================================
Files 451 448 -3
Lines 58586 58247 -339
=========================================
- Hits 50402 50113 -289
+ Misses 8184 8134 -50
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MichaelScofield
approved these changes
Dec 6, 2022
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…#714) * refactor: drop support of physical plan query interface Signed-off-by: Ruihang Xia <[email protected]> * refactor: collapse server/grpc sub-module Signed-off-by: Ruihang Xia <[email protected]> * refactor: remove unused errors Signed-off-by: Ruihang Xia <[email protected]> Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This refactor mainly removes the query interface with DataFusion Physical Plan, which is added in #212 by @Fengys123 . As now frontend and datanode are communicating with logical plan (implemented in #704), we do not need to support physical plan. And it can also alleviate the work on migrating datafusion in #555
Checklist
Refer to a related PR or issue link (optional)