-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Substrait logical plan #704
feat: Substrait logical plan #704
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #704 +/- ##
===========================================
- Coverage 86.06% 86.05% -0.01%
===========================================
Files 451 451
Lines 58564 58661 +97
===========================================
+ Hits 50401 50479 +78
- Misses 8163 8182 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@waynexia resolved, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General looks good to me, and I left a few comments about style.
8f010df
to
911fafc
Compare
@waynexia resolved, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: use Substrait logical plan to query data from Datanode in Frontend in distributed mode * fix: resolve PR comments * fix: resolve PR comments * fix: resolve PR comments Co-authored-by: luofucong <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Use Substrait logical plan to execute query between Frontend and Datanode, in distributed mode. Formerly we are converting table scan to SQL, which is not elegant.
Checklist
Refer to a related PR or issue link (optional)
#682
#597
#532