refactor: execute insert with select in query engine #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelScofield
requested review from
killme2008,
sunng87,
evenyag and
waynexia
MichaelScofield
commented
Mar 15, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1181 +/- ##
===========================================
- Coverage 85.21% 84.88% -0.33%
===========================================
Files 495 495
Lines 72592 72344 -248
===========================================
- Hits 61859 61412 -447
- Misses 10733 10932 +199 |
MichaelScofield
force-pushed
the
refactor/insert-by-plan
branch
from
abeac27
to
19f59fa
Compare
killme2008
reviewed
Mar 22, 2023
MichaelScofield
force-pushed
the
refactor/insert-by-plan
branch
from
19f59fa
to
e1efc8a
Compare
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* refactor: execute insert with select in query engine * fix: resolve PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Insert with select is now executed in query engine. Also insert with select is made possible in distributed mode.
However, plain insert (insert with values) is still executed in the form of statement, directly.
Checklist
Refer to a related PR or issue link (optional)
#1010
close #760