Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports INSERT INTO SELECT statement #760

Closed
killme2008 opened this issue Dec 16, 2022 · 11 comments · Fixed by #1025 or #1181
Closed

Supports INSERT INTO SELECT statement #760

killme2008 opened this issue Dec 16, 2022 · 11 comments · Fixed by #1025 or #1181
Assignees
Labels
C-enhancement Category Enhancements
Milestone

Comments

@killme2008
Copy link
Contributor

What type of enhancement is this?

API improvement

What does the enhancement do?

Using it to copy data from one table and inserts it into another table, such as:

INSERT INTO table2 SELECT * FROM table1 WHERE condition;

Implementation challenges

No response

@killme2008 killme2008 added the C-enhancement Category Enhancements label Dec 16, 2022
@killme2008 killme2008 mentioned this issue Dec 27, 2022
2 tasks
@francis-du
Copy link
Contributor

Hi,Has anyone claimed this issue? If not, can you assign it to me? I want to try it.

@waynexia
Copy link
Member

Glad you're interested. This is a relatively complex feature. Feel free to reach out to us and share your question if any 😄

@francis-du
Copy link
Contributor

Glad you're interested. This is a relatively complex feature. Feel free to reach out to us and share your question if any 😄

Hi, Ruihang. About SQL Parser I think I don't need any help. I would like to ask about Insert data how do I start?

@waynexia
Copy link
Member

My general thought is to make INSERT able to invoke the query engine if there is no plain data, but another query like SELECT in this issue. And insert data from the evaluated query like normal INSERT. I think Instance is a good place to make this deal, as it keeps both QueryEngine and Table (via CatalogManager).

@francis-du
Copy link
Contributor

My general thought is to make INSERT able to invoke the query engine if there is no plain data, but another query like SELECT in this issue. And insert data from the evaluated query like normal INSERT. I think Instance is a good place to make this deal, as it keeps both QueryEngine and Table (via CatalogManager).

Thank you, Ruihang.

@killme2008
Copy link
Contributor Author

@francis-du Hi, are u still working on this feature? The #405 may depend on it.

@francis-du
Copy link
Contributor

@francis-du Hi, are u still working on this feature? The #405 may depend on it.

Yeah. I just finished my vacation, next I will speed up on this.

@evenyag
Copy link
Contributor

evenyag commented Jan 31, 2023

Is it possible to divide this into some small tasks (or steps) and track them in a tracking issue? So more people could get involved in. @francis-du @killme2008

@killme2008
Copy link
Contributor Author

Is it possible to divide this into some small tasks (or steps) and track them in a tracking issue? So more people could get involved in. @francis-du @killme2008

Agree. We want to release this feature in 0.1-beta(maybe on 15th Feb), I think we can create an issue to track the tasks. @francis-du

@waynexia waynexia added this to the Release v0.1 milestone Feb 1, 2023
@fengjiachun
Copy link
Collaborator

Hi, @francis-du , due to the length of time and we want to release this feature in 0.1-beta(maybe on 15th Feb), we have automatically unsign, so please continue to pick up other tasks if needed.

@killme2008
Copy link
Contributor Author

We have to implement it in distributed mode too. It's related to #1010 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements
Projects
None yet
6 participants