-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MUI2 dep to RC2 #2622
base: master
Are you sure you want to change the base?
Update MUI2 dep to RC2 #2622
Conversation
329017d
to
1f0f653
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Ghost Circuit shift-click selector popup doesn't seem to work. No panel is created when shift left clicking.
In the Ender Fluid Link Cover, when a Fluid Filter is added, if you open the fluid filter settings, you cannot drag the panel when you click on the title (TextWidget), you can only drag the panel when clicking on the actual panel. This is not that great, as the panel is a bit small, and filled with things that block you from dragging it. (This was possible in RC1, so something changed, either on MUI end or in this PR).
In addition, once you start dragging the panel, you cannot stop dragging the panel. Clicking anywhere with the panel when it is being dragged does not park the panel in the clicked location.
No tooltips are present on any of the buttons, except for the lock button and the entry selector, in the Ender Fluid Link cover GUI, though I cannot remember if this was the case before this PR
When dragging a panel, you can still pick up items out of your inventory onto your mouse cursor. This probably should not be allowed.
You can no longer shift click to open covers when they are your selected item
A lot of buttons feel like they are missing tooltips when they previously had tooltips.
Something is going wrong with the Multifluid hatches. I clicked a stack of 45 cells into a multifluid input, all fluid went it. I tried to grab the fluid back with the 45 cells, and only 44 cells were filled. I could repeat this several times. I then closed the GUI and reopened it, tried clicking on the 1 B of fluid with a cell, but it deleted itself.
...ava/gregtech/common/metatileentities/multi/multiblockpart/MetaTileEntityMultiFluidHatch.java
Outdated
Show resolved
Hide resolved
these are all things that should be fixed in MUI2
I'm able to open the filter ui when right clicking with a filter selected in the hotbar, but that functionality was never implemented for other covers so idk what you mean exactly. Shift right-clicking prevents the ui from being opened so the NBT can cleared.
already fixed in mui2 dev
this is now fixed |
2cdb2c0
to
0c9df08
Compare
this pr is on hold and should not be merged until mui2 rc3 or later is released |
b02233a
to
d966240
Compare
I've decided to fix the issues with MUI2 via mixin, so that this pr doesn't need to wait for the next mui update and to fix issues with other/future mui2 port prs. This pr can be looked at now. |
781f7c1
to
baaa88c
Compare
fix more issues
simplify loop
spotless
don't need background
add default size fields remove manually calling click sound
sync changes to tank fluid automatically work on supporting phantom fluid slot
move showAmount to GTFluidSyncHandler use GTFluidSlot for SimpleFluidFilter
port and utilize it in MetaTileEntityFluidHatch
various fixes/improvements to MetaTileEntityFluidHatch
improve lock toggle slightly
fix defaults for StyledTextMixin
e13bbf3
to
3aaada1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a popout panel is over the JEI deletion area (and you are in cheat mode with an item held in the cursor), the deletion tooltip get rendered on top of the item tooltip.
In the Ender Fluid Link cover, setting the description of a fluid channel does not show the new description until the GUI is exited and re-entered.
The Fluid Export Hatch does not display the fluid tooltip over the locked fluid in the GUI.
For the ghost circuit selector panel, could we add in shift + click to set the circuit and automatically close the selector panel? Doesn't have to be in this PR.
Is it just me, or is the chemical formula tooltip for fluids closer to the fluid name in the fluid filter slot than when hovering over a bucket of the fluid?
In the advanced fluid voiding cover, when the cover is in Void Overflow mode, the fluid amount value no longer displays on fluids in the fluid filter. Same with the Fluid Regulator in supply exact mode.
The issue where you throw items off of your cursor when trying to configure filters that are not over the main inventory has returned. Only for Fluid Filters though.
When a new version of MUI2 eventually gets published, we will need to bump the version requirement in GregTechMod
...ain/java/gregtech/common/metatileentities/multi/multiblockpart/MetaTileEntityFluidHatch.java
Outdated
Show resolved
Hide resolved
...ain/java/gregtech/common/metatileentities/multi/multiblockpart/MetaTileEntityFluidHatch.java
Show resolved
Hide resolved
...ain/java/gregtech/common/metatileentities/multi/multiblockpart/MetaTileEntityFluidHatch.java
Outdated
Show resolved
Hide resolved
...ain/java/gregtech/common/metatileentities/multi/multiblockpart/MetaTileEntityFluidHatch.java
Outdated
Show resolved
Hide resolved
...ain/java/gregtech/common/metatileentities/multi/multiblockpart/MetaTileEntityFluidHatch.java
Show resolved
Hide resolved
.key('F', i -> new GTFluidSlot() | ||
.syncHandler(GTFluidSlot.sync(filterReader.getFluidTank(i)) | ||
.phantom(true) | ||
.showAmount(false))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this showAmount
here be messing with the Advanced Voiding Cover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
somewhat, i'll need to figure out a way to pass information from the regulator/voiding cover down to the filter's sync handler
What
updates mui2 dep to rc2
ports multi fluid tank hatches to mui2 to test our fluid slot impl
port single take fluid hatches to test fluid locking
fixes issues in mui2 via mixin
Implementation Details
new Row()
->Flow.row()
new Column()
->Flow.coloumn()
GuiData
is now passed in to mui methods instead of main panelreworks abstract ender cover ui because extending PanelSyncHandler is no longer desirable
FixedFluidSlotSH
has been merged withGTFluidSlotSyncHandler
Tooltip
is deprecated and replaced withRichTooltip
and other stuff
need to check these things to make sure they still work
Outcome
another step for the road to mui2