fix: remove unset grower ID from captures filter #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitia-anah
pushed a commit
to mitia-anah/treetracker-admin-client
that referenced
this pull request
Feb 1, 2022
Ny-Rianala
pushed a commit
to Ny-Rianala/treetracker-admin-client
that referenced
this pull request
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Grower ID (
planterId) is no longer passed to the captures query if it is not set in the filter.For consistency with the filter UI inputs for Capture ID and Grower ID, these values should both be strings.
Issue(s) addressed
What kind of change(s) does this PR introduce?
Please check if the PR fulfils these requirements
Issue
What is the current behaviour?
When Grower ID is not set in the Captures filter, an empty
planterIdstring is passed to the query, resulting in zero results.What is the new behaviour?
planterIdis omitted from the query when Grower ID is blank, meaning captures for all growers are returned.Breaking change
Does this PR introduce a breaking change?
No