Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Growers: Grower ID filter is applied when no value is selected #244

Closed
nmcharlton opened this issue Dec 13, 2021 · 0 comments · Fixed by #245
Closed

Growers: Grower ID filter is applied when no value is selected #244

nmcharlton opened this issue Dec 13, 2021 · 0 comments · Fixed by #245
Assignees
@nmcharlton
Labels
priority High priority issue size: small Simple change tool: Captures Relates to the capture data tool (Captures page, formerly Trees) type: bug Something isn't working

Comments

@nmcharlton
Copy link
Collaborator

Present in v1.31.1.

When a user filters the Growers tool without selecting a grower ID (planterId in the api), the field is passed to the where clause in the filter query anyway as an empty string:

api/trees?filter={"where":{"approved":false,"active":true,"planterId":""}, ... }

This means that no results are returned.
@nmcharlton nmcharlton added type: bug Something isn't working priority High priority issue size: small Simple change tool: Captures Relates to the capture data tool (Captures page, formerly Trees) labels Dec 13, 2021
@nmcharlton nmcharlton self-assigned this Dec 13, 2021
@nmcharlton nmcharlton mentioned this issue Dec 13, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmcharlton nmcharlton

Labels
priority High priority issue size: small Simple change tool: Captures Relates to the capture data tool (Captures page, formerly Trees) type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove unset grower ID from captures filter nmcharlton/treetracker-admin-client
1 participant
@nmcharlton