fix: issue_94 #113
Closed
fix: issue_94 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panzaverdeok
requested review from
gwynndp,
luacmartins and
nmcharlton
as code owners
nmcharlton
requested changes
Jun 12, 2021
There was a problem hiding this comment.
@panzaverdeok I've requested some changes. Please ask if you want some help with them.
| @@ -214,7 +214,7 @@ function Filter(props) { | |||
| format={getDateFormatLocale(true)} | |||
| value={dateStart} | |||
| onChange={handleDateStartChange} | |||
| maxDate={dateEnd} | |||
| //maxDate={dateEnd} Conrado Banegas comment 6/2021 issue #94 | |||
There was a problem hiding this comment.
A few comments:
- We shouldn't remove
maxDate, but should set it to today's date ifdateEndisnullorundefined. - The same problem exists with
minDateon the End DateKeyboardDatePicker(line 229). WhendateStartisnullorundefined, this should be set to a sensible minimum (e.g.,Date(1900-01-01)). - If code is not needed, don't comment it out – remove it. We can use git to see what has been removed and put it back in if necessary.
- There's no need to add comments like this to the code. After a while they get in the way of the code and cause the files to bloat. GitHub tracks line-by-line changes for us and we link commits to issues via PRs.
There was a problem hiding this comment.
Hi Nick.
It' ok, I'll try to develop another alternativa to solve the issue.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #94