Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter date selection: Cannot move forward #94

Closed
nmcharlton opened this issue May 24, 2021 · 3 comments · Fixed by #140
Closed

Filter date selection: Cannot move forward #94

nmcharlton opened this issue May 24, 2021 · 3 comments · Fixed by #140
Assignees
Labels
good first issue Good for newcomers size: small Simple change tool: Captures Relates to the capture data tool (Captures page, formerly Trees) tool: Verify Relates to the capture verification tool (Verify page) type: bug Something isn't working

Comments

@nmcharlton
Copy link
Collaborator

The forward button on the date selector used in filters on the Verify and Trees pages is permanently disabled, meaning you can't navigate to the next month if you go back.
Instead, you need to close the date selector and reopen it.

Screen.Recording.2021-05-24.at.20.02.34.mov
@nmcharlton nmcharlton added type: bug Something isn't working good first issue Good for newcomers tool: Verify Relates to the capture verification tool (Verify page) size: small Simple change tool: Captures Relates to the capture data tool (Captures page, formerly Trees) labels May 24, 2021
@panzaverdeok
Copy link

Hi @nmcharlton
I'm working in this issue.

I'll keeping you to the advance.

Regards.

@panzaverdeok
Copy link

Hey @nmcharlton !

I think that was solve issue. I did some test into local enviroment, these tests was a ok. However, in relation to I have readed, think must pull on my git personal branch, do test and finally merge the solution into production enviroment. Please, could you says me how I must continue?

The issue was into FilterTop.js component, KeyboardDatePicker, minDate and maxDate parameters.
I will document complete the issue and solution next days.

Regards.

@nmcharlton
Copy link
Collaborator Author

@panzaverdeok You need to push your feature branch to your origin (git push origin <branch-name>) and create a pull request in GitHub from your local fork into Greenstand/treetracker-admin-client: master.

Once you have a pull request open, I can review your changes and merge them into the Greenstand repo.
If there are any conflicts raised in the pull request, we will need to resolve them before merging.

Let me know if you need any help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers size: small Simple change tool: Captures Relates to the capture data tool (Captures page, formerly Trees) tool: Verify Relates to the capture verification tool (Verify page) type: bug Something isn't working
Projects
None yet
2 participants