Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement If-diff script #711

Merged
merged 23 commits into from
May 28, 2024
Merged

implement If-diff script #711

merged 23 commits into from
May 28, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Implement if-diff script.

@narekhovhannisyan narekhovhannisyan self-assigned this May 15, 2024
@narekhovhannisyan narekhovhannisyan linked an issue May 15, 2024 that may be closed by this pull request
12 tasks
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if-diff is returning a failure response based on execution.command which is supposed to be a ignored field.
Please ignore all information in execution EXCEPT status and error.

@narekhovhannisyan
Copy link
Member Author

@jmcook1186 it will be covered with #706

Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm - I checked out locally and verified that:

  • two identical files return success response
  • two non-matching files returned failure response and expected diff report
  • piping from ie to if-diff worked as expected

Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must fix #734
and #733 from QA review
before this can be merged

Copy link
Contributor

@MariamKhalatova MariamKhalatova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narekhovhannisyan In case of using wildcard , the '*' is accepted as a value, and an error is received.

Files do not match!
tree.children.child-0.outputs[0].cpu/utilization
source: *
target: 20

Copy link
Contributor

@MariamKhalatova MariamKhalatova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narekhovhannisyan When the quantity of array members doesn't match in source and target files, then the following error is received.
Expected result: Should show the first missing array member

Files do not match!
tree.children.child-0.outputs
source: [object Object]
target: [object Object],[object Object],[object Object]

@narekhovhannisyan
Copy link
Member Author

fixes #733
fixes #734

Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm!

@MariamKhalatova MariamKhalatova merged commit 9b49631 into main May 28, 2024
2 checks passed
@MariamKhalatova MariamKhalatova deleted the if-diff branch May 28, 2024 08:42
This was referenced Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[If-diff] Only first array member is validated If-diff throws unexpected error Build if-diff core feature
3 participants