-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement If-diff
script
#711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if-diff
is returning a failure response based on execution.command
which is supposed to be a ignored field.
Please ignore all information in execution
EXCEPT status
and error
.
@jmcook1186 it will be covered with #706 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm - I checked out locally and verified that:
- two identical files return success response
- two non-matching files returned failure response and expected diff report
- piping from
ie
toif-diff
worked as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@narekhovhannisyan In case of using wildcard , the '*' is accepted as a value, and an error is received.
Files do not match!
tree.children.child-0.outputs[0].cpu/utilization
source: *
target: 20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@narekhovhannisyan When the quantity of array members doesn't match in source and target files, then the following error is received.
Expected result: Should show the first missing array member
Files do not match!
tree.children.child-0.outputs
source: [object Object]
target: [object Object],[object Object],[object Object]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm!
Types of changes
A description of the changes proposed in the Pull Request
if-diff
script.