Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If-diff throws unexpected error #726

Closed
MariamKhalatova opened this issue May 21, 2024 · 2 comments · Fixed by #711
Closed

If-diff throws unexpected error #726

MariamKhalatova opened this issue May 21, 2024 · 2 comments · Fixed by #711
Assignees
Labels
bug Error, flaw or fault

Comments

@MariamKhalatova
Copy link
Contributor

Description of the Error

Comparing two random manifests ended up with ManifestValidationError: "execution" parameter is required. Error code: invalid_type.

Expected Behaviour

If-diff should show the differences.

Actual Behaviour

Comparing two random manifests ended up with ManifestValidationError: "execution" parameter is required. Error code: invalid_type.

Steps to Reproduce

npm the if diff script with following command

npm run if-diff -- -s manifests/bugs/aggregation-error-wrong-metric.yml -t manifests/bugs/azure-importer-incorrect-calculation.yml
@MariamKhalatova MariamKhalatova added bug Error, flaw or fault qa labels May 21, 2024
@MariamKhalatova MariamKhalatova linked a pull request May 21, 2024 that will close this issue
9 tasks
@zanete zanete mentioned this issue May 21, 2024
12 tasks
@jmcook1186
Copy link
Contributor

jmcook1186 commented May 21, 2024

In its current form if-diff should compare output files not manifests. The execution section is only available in output files.

So I don't think this is really a bug.
@MariamKhalatova

@jmcook1186 jmcook1186 moved this to Testing in IF May 21, 2024
@MariamKhalatova
Copy link
Contributor Author

@jmcook1186 Yes, if we compare only outputs, then this is not a bug. Will close it

@MariamKhalatova MariamKhalatova closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
@github-project-automation github-project-automation bot moved this from Testing to Done in IF May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Error, flaw or fault
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants