Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds tdp-finder model to models-universe and adds impl #192

Closed
wants to merge 15 commits into from
Closed

adds tdp-finder model to models-universe and adds impl #192

wants to merge 15 commits into from

Conversation

jmcook1186
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Patches PR #174 by:

  • rebasing onto latest dev
  • adding new model to models-universe.ts
  • exporting new model from lib
  • adding an example impl that invokes the tdp-finder

gnanakeethan and others added 15 commits October 2, 2023 11:22
@gnanakeethan
Remove JSII
a044044 
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
@gnanakeethan
Fix version
fd60f43 
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
@gnanakeethan
Adding tsconfig
8d8bb20 
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
@jmcook1186
Merge pull request #182 from Green-Software-Foundation/jsii-removal
a1b0c55 
Remove JSII
@gnanakeethan @jmcook1186
Adding data and config
fa81bd6 
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
@gnanakeethan @jmcook1186
TDP finder update: Split name with @ and use the prefix
8b94639 
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
@gnanakeethan @jmcook1186
Update: TDP finder fixing handling of names
c2db38c 
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
@gnanakeethan @jmcook1186
Update: TDP Finder fixing test
30f6233 
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
@gnanakeethan @jmcook1186
Adding documentation
99ce52c 
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
@gnanakeethan @jmcook1186
Default node version to 18
78f5a8e 
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
@gnanakeethan @jmcook1186
Typo fix
3079013 
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
@gnanakeethan @jmcook1186
Compat with the Cloud instance metadata model
46686e5 
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
@jmcook1186
Merge branch '173-tdp-finder-model' of https://github.com/Green-Softw…
022bd92 
…are-Foundation/ief into 173-tdp-finder-model
@jmcook1186
adds tdp-finder to models library & adds test impl
18e7f31
@jmcook1186
lint
5356c2e
@gnanakeethan
Copy link
Contributor

@jmcook1186 Can I cherry pick instead?

@gnanakeethan gnanakeethan deleted the tdp-finder-jc-patch branch November 9, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnanakeethan gnanakeethan Awaiting requested review from gnanakeethan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcook1186 @gnanakeethan