Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JSII #182

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Remove JSII #182

merged 3 commits into from
Oct 10, 2023

Conversation

gnanakeethan
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

@gnanakeethan
Remove JSII
a044044 
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
@gnanakeethan gnanakeethan linked an issue Oct 2, 2023 that may be closed by this pull request
JSII has been removed #179
Closed
@gnanakeethan
Fix version
fd60f43 
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
@gnanakeethan gnanakeethan marked this pull request as ready for review October 7, 2023 04:22
@gnanakeethan
Adding tsconfig
8d8bb20 
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
jmcook1186
jmcook1186 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - tested locally using complex-pipeline.yml

@jmcook1186 jmcook1186 merged commit a1b0c55 into dev Oct 10, 2023
2 checks passed
@jmcook1186 jmcook1186 deleted the jsii-removal branch October 10, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@narekhovhannisyan narekhovhannisyan Awaiting requested review from narekhovhannisyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSII has been removed
2 participants
@gnanakeethan @jmcook1186