Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DDIDS-1152, DDIDS-1213): Table component number column styling #1033

Merged
merged 1 commit into from
Feb 10, 2023
Merged

feat(DDIDS-1152, DDIDS-1213): Table component number column styling #1033

merged 1 commit into from
Feb 10, 2023

Conversation

amar-ABgov
Copy link
Contributor

@amar-ABgov amar-ABgov commented Feb 7, 2023 •
edited
Loading

TIcket

https://goa-dio.atlassian.net/browse/DDIDS-1152
https://goa-dio.atlassian.net/browse/DDIDS-1213

Changes

  • Added a new package to support the use of :global with svelte custom components. Details

chrisolsen
chrisolsen previously approved these changes Feb 7, 2023
View reviewed changes
@Radha-Alberta
Copy link
Contributor

The height of the row is increased after adding class "goa-table-number-column" to a td cell (Refer to the second row in the below example).
image

@amar-ABgov
Copy link
Contributor Author

@ArakTaiRoth I addressed the styling issue caught by @Radha-Alberta ☝️
This should also fix https://goa-dio.atlassian.net/browse/DDIDS-1213. So including that ticket as well in this PR

@amar-ABgov amar-ABgov changed the title feat(DDIDS-1152): Table component number column styling feat(DDIDS-1152, DDIDS-1213): Table component number column styling Feb 9, 2023
@chrisolsen chrisolsen self-requested a review February 10, 2023 21:55
@ArakTaiRoth ArakTaiRoth merged commit 49aba53 into GovAlta:alpha Feb 10, 2023
@tzuge
Copy link
Collaborator

tzuge commented Feb 10, 2023

🎉 This PR is included in version 4.0.0-alpha.113 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Feb 10, 2023
@tzuge
Copy link
Collaborator

tzuge commented Feb 10, 2023

🎉 This PR is included in version 1.0.0-alpha.153 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 22, 2023

🎉 This PR is included in version 2.0.0-alpha.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 27, 2023

🎉 This PR is included in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Feb 27, 2023
@tzuge
Copy link
Collaborator

tzuge commented Feb 27, 2023

🎉 This PR is included in version 4.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 27, 2023

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 9, 2023

🎉 This PR is included in version 1.0.0-alpha.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 19, 2023

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArakTaiRoth ArakTaiRoth ArakTaiRoth approved these changes

@chrisolsen chrisolsen chrisolsen approved these changes

@Radha-Alberta Radha-Alberta Awaiting requested review from Radha-Alberta

@vanessatran-ddi vanessatran-ddi Awaiting requested review from vanessatran-ddi vanessatran-ddi is a code owner

Assignees
No one assigned
Labels
released on @alpha Released into alpha. released Released into production.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amar-ABgov @Radha-Alberta @tzuge @chrisolsen @ArakTaiRoth